diff options
| author | James E. Blair <jim@acmegating.com> | 2023-04-10 09:44:47 -0700 |
|---|---|---|
| committer | James E. Blair <jim@acmegating.com> | 2023-04-10 11:14:00 -0700 |
| commit | 70077ee6d5ab254c02294a6d0f6c6f518d16d96a (patch) | |
| tree | b8a6f872caa57cffd07de4953593215e3bc3a55f /playbooks/zuul-stream/fixtures/test-stream.yaml | |
| parent | b2dc863b44d6b546f6609cfe8707f40c55b8aede (diff) | |
| download | zuul-70077ee6d5ab254c02294a6d0f6c6f518d16d96a.tar.gz | |
Do not wait for streamer when disabled
When a user sets zuul_console_disabled, we don't need to try to
connect to the streaming daemon. In fact, they may have set it
because they know it won't be running. Check for this and avoid
the connection step in that case and therefore avoid the extraneous
"Waiting on logger" messages and extra 30 second delay at the end
of each task.
Change-Id: I86af231f1ca1c5b54b21daae29387a8798190a58
Diffstat (limited to 'playbooks/zuul-stream/fixtures/test-stream.yaml')
| -rw-r--r-- | playbooks/zuul-stream/fixtures/test-stream.yaml | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/playbooks/zuul-stream/fixtures/test-stream.yaml b/playbooks/zuul-stream/fixtures/test-stream.yaml index 488f8cb2f..49ceb092b 100644 --- a/playbooks/zuul-stream/fixtures/test-stream.yaml +++ b/playbooks/zuul-stream/fixtures/test-stream.yaml @@ -1,3 +1,16 @@ +# NOTE: We run this before starting the log streaming to validate that +# if we set zuul_console_disabled, we don't try to connect at all. If +# there is a log streamer running when we run this test, then we have +# no indication that we avoid the connection step. +- name: Run command to show skipping works without zuul_console running + vars: + zuul_console_disabled: true + hosts: node + tasks: + - name: Run quiet command + command: echo 'This command should not stream' + when: new_console | default(false) + - name: Start zuul stream daemon hosts: node tasks: @@ -11,7 +24,7 @@ port: 19887 when: new_console | default(false) -- name: Run command to show skipping works +- name: Run command to show skipping works with zuul_console running vars: zuul_console_disabled: true hosts: node |