diff options
| author | Tobias Henkel <tobias.henkel@bmw.de> | 2020-08-31 13:38:53 +0200 |
|---|---|---|
| committer | Tobias Henkel <tobias.henkel@bmw.de> | 2020-09-03 19:08:20 +0200 |
| commit | b2f6d48cc5d27599a5f4fabb6ddfb5768b575baa (patch) | |
| tree | 1e6f3efb062bdc0bc0a37dbd9330c7e4cbb57976 /releasenotes | |
| parent | 09866739909b67ae21aeaf0b685dbc6a1f7c8af5 (diff) | |
| download | zuul-b2f6d48cc5d27599a5f4fabb6ddfb5768b575baa.tar.gz | |
Handle review requirements in canMerge
Since GitHub 2.21 we now can query the reviewDecision flag on a PR
which tells us if a review is required and if it's approved or not
[1]. This can be leveraged in the canMerge check so we now finally can
accurately check if a change is allowed to enter the gate.
[1] https://developer.github.com/enterprise/2.21/v4/object/pullrequest/
Change-Id: I792a28b9f3c7d40ac21e22438bd7c09d3174cbb2
Diffstat (limited to 'releasenotes')
| -rw-r--r-- | releasenotes/notes/github-review-requirement-874b2dd8c6fa1292.yaml | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/releasenotes/notes/github-review-requirement-874b2dd8c6fa1292.yaml b/releasenotes/notes/github-review-requirement-874b2dd8c6fa1292.yaml new file mode 100644 index 000000000..312db7f8c --- /dev/null +++ b/releasenotes/notes/github-review-requirement-874b2dd8c6fa1292.yaml @@ -0,0 +1,6 @@ +--- +features: + - | + Zuul now respects GitHub review requirements when enqueuing into gate + pipelines. This works for github.com and GitHub Enterprise starting with + version 2.21.0. |