Add Gerrit pipeline trigger requirements

This updates the Gerrit driver to match the pattern in the GitHub
driver where instead of specifying individual trigger
requirements such as "require-approvals", instead a complete ref
filter (a la "requirements") can be embedded in the trigger
filter.

The "require-approvals" and "reject-approvals" attributes are
deprecated in favor of the new approach.

Additionally, all require filters in Gerrit are now available as
reject filters.

And finally, the Gerrit filters are updated to return
FalseWithReason so that log messages are more useful, and the
Github filters are updated to improve the language, avoid
apostraphes for ease of grepping, and match the new Gerrit
filters.

Change-Id: Ia9c749f1c8e318fe01e84e52831a9d0d2c10b203

1 files changed, 162 insertions, 0 deletions

diff --git a/tests/fixtures/layouts/gerrit-trigger-requirements.yaml b/tests/fixtures/layouts/gerrit-trigger-requirements.yaml
new file mode 100644
index 000000000..72ad6b41e
--- /dev/null
+++ b/tests/fixtures/layouts/gerrit-trigger-requirements.yaml
@@ -0,0 +1,162 @@
+- pipeline:
+    name: require-open
+    manager: independent
+    trigger:
+      gerrit:
+        - event: comment-added
+          comment: test require-open
+          require:
+            open: true
+    success:
+      gerrit:
+        Verified: 1
+
+- pipeline:
+    name: reject-open
+    manager: independent
+    trigger:
+      gerrit:
+        - event: comment-added
+          comment: test reject-open
+          reject:
+            open: true
+    success:
+      gerrit:
+        Verified: 1
+
+- pipeline:
+    name: require-wip
+    manager: independent
+    trigger:
+      gerrit:
+        - event: comment-added
+          comment: test require-wip
+          require:
+            wip: true
+    success:
+      gerrit:
+        Verified: 1
+
+- pipeline:
+    name: reject-wip
+    manager: independent
+    trigger:
+      gerrit:
+        - event: comment-added
+          comment: test reject-wip
+          reject:
+            wip: true
+    success:
+      gerrit:
+        Verified: 1
+
+- pipeline:
+    name: require-current-patchset
+    manager: independent
+    trigger:
+      gerrit:
+        - event: comment-added
+          comment: test require-current-patchset
+          require:
+            current-patchset: true
+    success:
+      gerrit:
+        Verified: 1
+
+- pipeline:
+    name: reject-current-patchset
+    manager: independent
+    trigger:
+      gerrit:
+        - event: comment-added
+          comment: test reject-current-patchset
+          reject:
+            current-patchset: true
+    success:
+      gerrit:
+        Verified: 1
+
+- pipeline:
+    name: require-status
+    manager: independent
+    trigger:
+      gerrit:
+        - event: comment-added
+          comment: test require-status
+          require:
+            status: MERGED
+    success:
+      gerrit:
+        Verified: 1
+
+- pipeline:
+    name: reject-status
+    manager: independent
+    trigger:
+      gerrit:
+        - event: comment-added
+          comment: test reject-status
+          reject:
+            status: MERGED
+    success:
+      gerrit:
+        Verified: 1
+
+- pipeline:
+    name: require-approval
+    manager: independent
+    trigger:
+      gerrit:
+        - event: comment-added
+          comment: test require-approval
+          require:
+            approval:
+              username: zuul
+              Verified: 1
+    success:
+      gerrit:
+        Verified: 1
+
+- pipeline:
+    name: reject-approval
+    manager: independent
+    trigger:
+      gerrit:
+        - event: comment-added
+          comment: test reject-approval
+          reject:
+            approval:
+              username: zuul
+              Verified: 1
+    success:
+      gerrit:
+        Verified: 1
+
+- job:
+    name: base
+    parent: null
+    run: playbooks/base.yaml
+
+- job: {name: require-open}
+- job: {name: reject-open}
+- job: {name: require-wip}
+- job: {name: reject-wip}
+- job: {name: require-current-patchset}
+- job: {name: reject-current-patchset}
+- job: {name: require-status}
+- job: {name: reject-status}
+- job: {name: require-approval}
+- job: {name: reject-approval}
+
+- project:
+    name: org/project
+    require-open: {jobs: [require-open]}
+    reject-open: {jobs: [reject-open]}
+    require-wip: {jobs: [require-wip]}
+    reject-wip: {jobs: [reject-wip]}
+    require-current-patchset: {jobs: [require-current-patchset]}
+    reject-current-patchset: {jobs: [reject-current-patchset]}
+    require-status: {jobs: [require-status]}
+    reject-status: {jobs: [reject-status]}
+    require-approval: {jobs: [require-approval]}
+    reject-approval: {jobs: [reject-approval]}