diff options
| author | James E. Blair <jeblair@redhat.com> | 2019-09-18 15:49:41 -0700 |
|---|---|---|
| committer | James E. Blair <jeblair@redhat.com> | 2019-09-20 07:26:04 -0700 |
| commit | b1ed58b1723710c04dcdf697190e6743f3f02c64 (patch) | |
| tree | 0ab5dde80bdadc805c37ce8ed7cac7ab13cbfa10 /tests/unit/test_gerrit_legacy_crd.py | |
| parent | b7839e755a3d9d3ad084c42c3406ceda54b300dd (diff) | |
| download | zuul-b1ed58b1723710c04dcdf697190e6743f3f02c64.tar.gz | |
Fix gerrit errors from production
This corrects the following errors.
Test fixture errors:
* Unlike the SSH API, the Gerrit REST API does not include
COMMIT_MSG in the list of files.
* We weren't checking all elements of the (change id, branch,
project) tuple when searching for change ids
* I observed a race around poll synchronization; I can't figure it out
so I've added more debug log lines.
Production errors:
* Break after the first successful submit rather than attemping the
call multiple times in all cases. This was non-fatal.
* Only attempt to get the remote version if using HTTP. This was
non-fatal.
* URLquote search queries (they may contain '#'). The additional CRD
tests cover this now.
* Coerce the list of files to a list rather than a dict_keys instance.
The new single file test covers this.
Change-Id: I89a68b2d189b82f0bc64e78fbc875d5628cc2cf0
Diffstat (limited to 'tests/unit/test_gerrit_legacy_crd.py')
| -rw-r--r-- | tests/unit/test_gerrit_legacy_crd.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tests/unit/test_gerrit_legacy_crd.py b/tests/unit/test_gerrit_legacy_crd.py index 515e2fa95..1ae2f862b 100644 --- a/tests/unit/test_gerrit_legacy_crd.py +++ b/tests/unit/test_gerrit_legacy_crd.py @@ -626,3 +626,7 @@ class TestGerritLegacyCRD(ZuulTestCase): self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(2)) self.waitUntilSettled() self.assertEqual(B.reported, 2) + + +class TestGerritLegacyCRDWeb(TestGerritLegacyCRD): + config_file = 'zuul-gerrit-web.conf' |