Add Gerrit pipeline trigger requirements

This updates the Gerrit driver to match the pattern in the GitHub
driver where instead of specifying individual trigger
requirements such as "require-approvals", instead a complete ref
filter (a la "requirements") can be embedded in the trigger
filter.

The "require-approvals" and "reject-approvals" attributes are
deprecated in favor of the new approach.

Additionally, all require filters in Gerrit are now available as
reject filters.

And finally, the Gerrit filters are updated to return
FalseWithReason so that log messages are more useful, and the
Github filters are updated to improve the language, avoid
apostraphes for ease of grepping, and match the new Gerrit
filters.

Change-Id: Ia9c749f1c8e318fe01e84e52831a9d0d2c10b203

1 files changed, 220 insertions, 1 deletions

diff --git a/tests/unit/test_requirements.py b/tests/unit/test_requirements.py
index 9f3b87187..c5dca56cd 100644
--- a/tests/unit/test_requirements.py
+++ b/tests/unit/test_requirements.py
@@ -14,7 +14,7 @@
 
 import time
 
-from tests.base import ZuulTestCase
+from tests.base import ZuulTestCase, simple_layout
 
 
 class TestRequirementsApprovalNewerThan(ZuulTestCase):
@@ -490,3 +490,222 @@ class TestRequirementsTrustedCheck(ZuulTestCase):
         self.fake_gerrit.addEvent(B.getPatchsetCreatedEvent(1))
         self.waitUntilSettled()
         self.assertHistory([])
+
+
+class TestGerritTriggerRequirements(ZuulTestCase):
+    scheduler_count = 1
+
+    @simple_layout('layouts/gerrit-trigger-requirements.yaml')
+    def test_require_open(self):
+        # Test trigger require-open
+        jobname = 'require-open'
+        project = 'org/project'
+        A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
+        # A comment event that we will keep submitting to trigger
+        comment = A.getChangeCommentEvent(1, f'test {jobname}')
+
+        # It's open, so it should be enqueued
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+        # Not open, so should be ignored
+        A.setMerged()
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+    @simple_layout('layouts/gerrit-trigger-requirements.yaml')
+    def test_reject_open(self):
+        # Test trigger reject-open
+        jobname = 'reject-open'
+        project = 'org/project'
+        A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
+        # A comment event that we will keep submitting to trigger
+        comment = A.getChangeCommentEvent(1, f'test {jobname}')
+
+        # It's open, so it should not be enqueued
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 0)
+
+        # Not open, so should be enqueued
+        A.setMerged()
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+    @simple_layout('layouts/gerrit-trigger-requirements.yaml')
+    def test_require_wip(self):
+        # Test trigger require-wip
+        jobname = 'require-wip'
+        project = 'org/project'
+        A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
+        # A comment event that we will keep submitting to trigger
+        comment = A.getChangeCommentEvent(1, f'test {jobname}')
+
+        # It's not WIP, so it should be ignored
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 0)
+
+        # WIP, so should be enqueued
+        A.setWorkInProgress(True)
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+    @simple_layout('layouts/gerrit-trigger-requirements.yaml')
+    def test_reject_wip(self):
+        # Test trigger reject-wip
+        jobname = 'reject-wip'
+        project = 'org/project'
+        A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
+        # A comment event that we will keep submitting to trigger
+        comment = A.getChangeCommentEvent(1, f'test {jobname}')
+
+        # It's not WIP, so it should be enqueued
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+        # WIP, so should be ignored
+        A.setWorkInProgress(True)
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+    @simple_layout('layouts/gerrit-trigger-requirements.yaml')
+    def test_require_current_patchset(self):
+        # Test trigger require-current_patchset
+        jobname = 'require-current-patchset'
+        project = 'org/project'
+        A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
+        # A comment event that we will keep submitting to trigger
+        comment = A.getChangeCommentEvent(1, f'test {jobname}')
+
+        # It's current, so it should be enqueued
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+        # Not current, so should be ignored
+        A.addPatchset()
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+    @simple_layout('layouts/gerrit-trigger-requirements.yaml')
+    def test_reject_current_patchset(self):
+        # Test trigger reject-current_patchset
+        jobname = 'reject-current-patchset'
+        project = 'org/project'
+        A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
+        # A comment event that we will keep submitting to trigger
+        comment = A.getChangeCommentEvent(1, f'test {jobname}')
+
+        # It's current, so it should be ignored
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 0)
+
+        # Not current, so should be enqueued
+        A.addPatchset()
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+    @simple_layout('layouts/gerrit-trigger-requirements.yaml')
+    def test_require_status(self):
+        # Test trigger require-status
+        jobname = 'require-status'
+        project = 'org/project'
+        A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
+        # A comment event that we will keep submitting to trigger
+        comment = A.getChangeCommentEvent(1, f'test {jobname}')
+
+        # It's not merged, so it should be ignored
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 0)
+
+        # Merged, so should be enqueued
+        A.setMerged()
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+    @simple_layout('layouts/gerrit-trigger-requirements.yaml')
+    def test_reject_status(self):
+        # Test trigger reject-status
+        jobname = 'reject-status'
+        project = 'org/project'
+        A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
+        # A comment event that we will keep submitting to trigger
+        comment = A.getChangeCommentEvent(1, f'test {jobname}')
+
+        # It's not merged, so it should be enqueued
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+        # Merged, so should be ignored
+        A.setMerged()
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+    @simple_layout('layouts/gerrit-trigger-requirements.yaml')
+    def test_require_approval(self):
+        # Test trigger require-approval
+        jobname = 'require-approval'
+        project = 'org/project'
+        A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
+        # A comment event that we will keep submitting to trigger
+        comment = A.getChangeCommentEvent(1, f'test {jobname}')
+
+        # Missing approval, so it should be ignored
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 0)
+
+        # Has approval, so it should be enqueued
+        A.addApproval('Verified', 1, username='zuul')
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+    @simple_layout('layouts/gerrit-trigger-requirements.yaml')
+    def test_reject_approval(self):
+        # Test trigger reject-approval
+        jobname = 'reject-approval'
+        project = 'org/project'
+        A = self.fake_gerrit.addFakeChange(project, 'master', 'A')
+        # A comment event that we will keep submitting to trigger
+        comment = A.getChangeCommentEvent(1, f'test {jobname}')
+
+        # Missing approval, so it should be enqueued
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)
+
+        # Has approval, so it should be ignored
+        A.addApproval('Verified', 1, username='zuul')
+        self.fake_gerrit.addEvent(comment)
+        self.waitUntilSettled()
+        self.assertEqual(len(self.history), 1)
+        self.assertEqual(self.history[0].name, jobname)