diff options
| author | Felix Edel <felix.edel@bmw.de> | 2021-02-18 14:08:56 +0100 |
|---|---|---|
| committer | James E. Blair <jim@acmegating.com> | 2021-03-08 07:15:32 -0800 |
| commit | 2dfb34a81800bd3973a6a62ee23d147cadae3cad (patch) | |
| tree | 93617bbb780532feeec078f9c3e5f21444cb798e /tests/unit/test_web_urls.py | |
| parent | 71a990d42a41cfe4e354509fec61de1f3b1cddcc (diff) | |
| download | zuul-2dfb34a81800bd3973a6a62ee23d147cadae3cad.tar.gz | |
Initialize ZooKeeper connection in server rather than in cmd classes
Currently, the ZooKeeper connection is initialized directly in the cmd
classes like zuul.cmd.scheduler or zuul.cmd.merger and then passed to
the server instance.
Although this makes it easy to reuse a single ZooKeeper connection for
multiple components in the tests it's not very realistic.
A better approach would be to initialize the connection directly in the
server classes so that each component has its own connection to
ZooKeeper.
Those classes already get all necessary parameters, so we could get rid
of the additional "zk_client" parameter.
Furthermore it would allow us to use a dedicated ZooKeeper connection
for each component in the tests which is more realistic than sharing a
single connection between all components.
Change-Id: I12260d43be0897321cf47ef0c722ccd74599d43d
Diffstat (limited to 'tests/unit/test_web_urls.py')
| -rw-r--r-- | tests/unit/test_web_urls.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/unit/test_web_urls.py b/tests/unit/test_web_urls.py index 1b017602e..6dd0eb386 100644 --- a/tests/unit/test_web_urls.py +++ b/tests/unit/test_web_urls.py @@ -27,7 +27,7 @@ class TestWebURLs(ZuulTestCase): def setUp(self): super(TestWebURLs, self).setUp() self.web = self.useFixture( - ZuulWebFixture(self.gearman_server.port, self.changes, self.config, + ZuulWebFixture(self.changes, self.config, self.additional_event_queues, self.upstream_root, self.rpcclient, self.poller_events, self.git_url_with_auth, self.addCleanup, |