Web: rely on new attributes when determining task failure

Now that the job-output.json file has attributes for 'failed' or
'skipped' tasks, rely on those rather than hueristics for determining
the result of a task.

Change-Id: I2714c5a1776970d5339aafe2ca5e17abf5a3bb0b

2 files changed, 0 insertions, 10 deletions

diff --git a/web/src/actions/build.js b/web/src/actions/build.js
index c61aa8189..afb881377 100644
--- a/web/src/actions/build.js
+++ b/web/src/actions/build.js
@@ -87,12 +87,6 @@ export function didTaskFail(task) {
   if (task.failed) {
     return true
   }
-  if ('failed_when_result' in task && !task.failed_when_result) {
-    return false
-  }
-  if ('rc' in task && task.rc) {
-    return true
-  }
   if (task.results) {
     for (let result of task.results) {
       if (didTaskFail(result)) {
diff --git a/web/src/actions/build.test.js b/web/src/actions/build.test.js
index a80aa5d0b..436d96dcc 100644
--- a/web/src/actions/build.test.js
+++ b/web/src/actions/build.test.js
@@ -17,10 +17,6 @@ import * as buildAction from './build'
 
 it('processes job-output properly', () => {
   expect(buildAction.didTaskFail({failed: true})).toEqual(true)
-  expect(buildAction.didTaskFail({failed_when_result: true})).toEqual(false)
-  expect(buildAction.didTaskFail({failed_when_result: false})).toEqual(false)
-  expect(buildAction.didTaskFail({failed: false, rc: 1})).toEqual(true)
-  expect(buildAction.didTaskFail({results: [{rc: 1}]})).toEqual(true)
 
   expect(buildAction.hasInterestingKeys({rc: 42}, ['rc'])).toEqual(true)
   expect(buildAction.hasInterestingKeys({noop: 42}, ['rc'])).toEqual(false)