summaryrefslogtreecommitdiff
path: root/web/src/containers/FilterToolbar.jsx
diff options
context:
space:
mode:
authorJames E. Blair <jim@acmegating.com>2021-07-16 15:54:41 -0700
committerJames E. Blair <jim@acmegating.com>2021-07-16 16:25:25 -0700
commit43a8e34559e594a33faafecfe9a0a33e52e25ee8 (patch)
tree7534993d9627985296713d2f1aa4a36e75aa61db /web/src/containers/FilterToolbar.jsx
parentcb613a1da94385f00f4691701a6cdf5619a0f4ac (diff)
downloadzuul-43a8e34559e594a33faafecfe9a0a33e52e25ee8.tar.gz
Don't display in-progress builds/buildsets in the web listing
The main purpose of the build and buildset listings is to find completed builds, not in-progress builds (that's the status page), so when we query the Zuul API, always set "completed=true". In the future, it might be nice to list in-progress builds on these pages, but that will require significantly more UI work to add it to the filter bar. Additionally, update the buildset page to show in-progress builds. It currently doesn't because it assumes all non-final builds are retry attemtps and therefore stores them under a secondary key. That's no longer true, and additionally, completed retried builds now have an explicit "RETRY" result which makes them easy for users to distinguish. It's more useful for a user to be able to see that a buildset is still in progress and also the retried builds (now that we store all of them), so this change returns all the builds of a buildset. Change-Id: I83d89c2903e6fd0aaf67c66f61d106b2c5db3797
Diffstat (limited to 'web/src/containers/FilterToolbar.jsx')
-rw-r--r--web/src/containers/FilterToolbar.jsx2
1 files changed, 1 insertions, 1 deletions
diff --git a/web/src/containers/FilterToolbar.jsx b/web/src/containers/FilterToolbar.jsx
index f1277a441..dcb7c4c43 100644
--- a/web/src/containers/FilterToolbar.jsx
+++ b/web/src/containers/FilterToolbar.jsx
@@ -233,7 +233,7 @@ function writeFiltersToUrl(filters, location, history) {
}
function buildQueryString(filters) {
- let queryString = ''
+ let queryString = '&complete=true'
if (filters) {
Object.keys(filters).map((key) => {
filters[key].forEach((value) => {