diff options
author | Zuul <zuul@review.opendev.org> | 2023-03-15 16:40:59 +0000 |
---|---|---|
committer | Gerrit Code Review <review@openstack.org> | 2023-03-15 16:40:59 +0000 |
commit | bac514e28c99af57635981767dd4329b680551de (patch) | |
tree | 17e4f2ca5a18fdc812ddea85495e4ee8fdeed435 /web/src/pages/Buildsets.jsx | |
parent | bc5bc85d9c3340975f9f5d6d3c3003db39421464 (diff) | |
parent | f848f251e45ab518cde3fa2be197d5694e4dac11 (diff) | |
download | zuul-bac514e28c99af57635981767dd4329b680551de.tar.gz |
Merge "Zuul-Web: Filter input validation for "Change""
Diffstat (limited to 'web/src/pages/Buildsets.jsx')
-rw-r--r-- | web/src/pages/Buildsets.jsx | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/web/src/pages/Buildsets.jsx b/web/src/pages/Buildsets.jsx index 98d86d640..938309034 100644 --- a/web/src/pages/Buildsets.jsx +++ b/web/src/pages/Buildsets.jsx @@ -148,6 +148,28 @@ class BuildsetsPage extends React.Component { } } + filterInputValidation = (filterKey, filterValue) => { + // Input value should not be empty for all cases + if (!filterValue) { + return { + success: false, + message: 'Input should not be empty' + } + } + + // For change filter, it must be an integer + if (filterKey === 'change' && isNaN(filterValue)) { + return { + success: false, + message: 'Change must be an integer (do not include revision)' + } + } + + return { + success: true + } + } + handleFilterChange = (newFilters) => { const { location, history } = this.props const { filters, itemCount } = this.state @@ -213,6 +235,7 @@ class BuildsetsPage extends React.Component { filterCategories={this.filterCategories} onFilterChange={this.handleFilterChange} filters={filters} + filterInputValidation={this.filterInputValidation} /> <Pagination toggleTemplate={({ firstIndex, lastIndex, itemCount }) => ( |