summaryrefslogtreecommitdiff
path: root/web/src/pages/Buildsets.jsx
diff options
context:
space:
mode:
authorJames E. Blair <jim@acmegating.com>2022-02-24 15:38:45 -0800
committerJames E. Blair <jim@acmegating.com>2022-02-24 17:06:03 -0800
commite03d8c887c092367b9ff2b00b48f244d4f6584f9 (patch)
tree043c71903b544ccc36505f89c2836a2daa72efa7 /web/src/pages/Buildsets.jsx
parent99b0eade8c42fab800d344555682c9e14c8b20aa (diff)
downloadzuul-e03d8c887c092367b9ff2b00b48f244d4f6584f9.tar.gz
Rename MERGER_FAILURE to MERGE_CONFLICT
This is a prelude to a change which will report a distinct buildset result to the database if the upstream code review system is unable to merge a change. Currently it is reported as MERGER_FAILURE which makes it difficult to distinguish from merge conflicts. Essentially, the two states we're interested in are when Zuul's merger is unable to prepare a git checkout of the change (99% of the time, this is a merge conflict). This will be known as MERGE_CONFLICT now. The second state is when Zuul asks Gerrit/Github/etc to submit/merge a change and the remote system is unable (or refuses) to do so. In a future change, that will be reported as MERGE_FAILURE. To avoid confusion and use names which better reflect the situation, this change performs the rename to MERGE_CONFLICT. Because there are pipeline configuration options tied to the MERGER_FAILURE status (which start with 'merge-failure') they are also renamed to 'merge-conflict'. The old names are supported for backwards compatibility. A SQL migration takes care of updating values in the database. The upgrade procedure is noted as being special because of the db value updates. If an operator doesn't follow the recommended procedure, however, the consequences are minimal (builds which won't be easily queried in the web ui; that can be manually corrected if desired). A model API change is not needed since the only place where we receive this value from ZK can be updated to accept both values. Change-Id: I3050409ed68805c748efe7a176b9755fa281536f
Diffstat (limited to 'web/src/pages/Buildsets.jsx')
-rw-r--r--web/src/pages/Buildsets.jsx2
1 files changed, 1 insertions, 1 deletions
diff --git a/web/src/pages/Buildsets.jsx b/web/src/pages/Buildsets.jsx
index f0d0e5277..382df5eb2 100644
--- a/web/src/pages/Buildsets.jsx
+++ b/web/src/pages/Buildsets.jsx
@@ -70,7 +70,7 @@ class BuildsetsPage extends React.Component {
options: [
'SUCCESS',
'FAILURE',
- 'MERGER_FAILURE',
+ 'MERGE_CONFLICT',
'DEQUEUED',
]
},