diff options
author | Felix Edel <felix.edel@bmw.de> | 2020-10-16 10:03:12 +0200 |
---|---|---|
committer | Felix Edel <felix.edel@bmw.de> | 2020-11-04 09:19:07 +0100 |
commit | f61da0a5e4236d63e19d2526e8f84781b00388ef (patch) | |
tree | 46f70cbd8f6d0b9f061438782b2f64d6da2be65f /web | |
parent | 7e131757a52b2bae73dfeb870cd551cd49fa47cd (diff) | |
download | zuul-f61da0a5e4236d63e19d2526e8f84781b00388ef.tar.gz |
UI: Remove refresh button from build and buildset page
Both the build and buildset doesn't change once stored in the SQL
database. Thus, clicking on the refresh button just reloads the same
information again which doesn't make much sense IMHO.
Since there is no other information on the build that would change over
time, simply remove the refresh button.
Change-Id: I3fccea38824cc4ffbda9d8619f548878b0a60542
Diffstat (limited to 'web')
-rw-r--r-- | web/src/containers/build/Build.jsx | 13 | ||||
-rw-r--r-- | web/src/containers/build/Buildset.jsx | 5 | ||||
-rw-r--r-- | web/src/pages/Build.jsx | 13 | ||||
-rw-r--r-- | web/src/pages/Buildset.jsx | 8 |
4 files changed, 7 insertions, 32 deletions
diff --git a/web/src/containers/build/Build.jsx b/web/src/containers/build/Build.jsx index 43d9b27ec..03b2d2704 100644 --- a/web/src/containers/build/Build.jsx +++ b/web/src/containers/build/Build.jsx @@ -16,13 +16,7 @@ import * as React from 'react' import PropTypes from 'prop-types' import { connect } from 'react-redux' import { Link } from 'react-router-dom' -import { - Flex, - FlexItem, - List, - ListItem, - Title, -} from '@patternfly/react-core' +import { Flex, FlexItem, List, ListItem, Title } from '@patternfly/react-core' import { BookIcon, BuildIcon, @@ -42,8 +36,7 @@ import 'moment-duration-format' import { BuildResultBadge, BuildResultWithIcon, IconProperty } from './Misc' import { buildExternalLink, ExternalLink } from '../../Misc' -function Build(props) { - const { build, tenant, timezone, fetchable } = props +function Build({ build, tenant, timezone }) { const build_link = buildExternalLink(build) return ( @@ -64,7 +57,6 @@ function Build(props) { {build.job_name} {!build.voting && ' (non-voting)'} </BuildResultWithIcon> <BuildResultBadge result={build.result} /> - {fetchable} </Title> {/* We handle the spacing for the body and the flex items by ourselves so they go hand in hand. By default, the flex items' spacing only @@ -244,7 +236,6 @@ Build.propTypes = { tenant: PropTypes.object, hash: PropTypes.array, timezone: PropTypes.string, - fetchable: PropTypes.node, } export default connect((state) => ({ diff --git a/web/src/containers/build/Buildset.jsx b/web/src/containers/build/Buildset.jsx index 2f275f270..23cd7e7bb 100644 --- a/web/src/containers/build/Buildset.jsx +++ b/web/src/containers/build/Buildset.jsx @@ -28,8 +28,7 @@ import { import { buildExternalLink } from '../../Misc' import { BuildResultBadge, BuildResultWithIcon, IconProperty } from './Misc' -function Buildset(props) { - const { buildset, fetchable } = props +function Buildset({ buildset }) { const buildset_link = buildExternalLink(buildset) return ( @@ -39,7 +38,6 @@ function Buildset(props) { Buildset result </BuildResultWithIcon> <BuildResultBadge result={buildset.result} /> - {fetchable} </Title> {/* We handle the spacing for the body and the flex items by ourselves so they go hand in hand. By default, the flex items' spacing only @@ -132,7 +130,6 @@ function Buildset(props) { Buildset.propTypes = { buildset: PropTypes.object, tenant: PropTypes.object, - fetchable: PropTypes.node, } export default connect((state) => ({ tenant: state.tenant }))(Buildset) diff --git a/web/src/pages/Build.jsx b/web/src/pages/Build.jsx index 9646f06f2..a7f48db5d 100644 --- a/web/src/pages/Build.jsx +++ b/web/src/pages/Build.jsx @@ -40,7 +40,7 @@ import { import { fetchBuildAllInfo } from '../actions/build' import { fetchLogfile } from '../actions/logfile' import { EmptyPage } from '../containers/Errors' -import { Fetchable, Fetching } from '../containers/Fetching' +import { Fetching } from '../containers/Fetching' import ArtifactList from '../containers/build/Artifact' import Build from '../containers/build/Build' import BuildOutput from '../containers/build/BuildOutput' @@ -156,10 +156,6 @@ class BuildPage extends React.Component { ) } - const fetchable = ( - <Fetchable isFetching={isFetching} fetchCallback={this.updateData} /> - ) - const resultsTabContent = build.hosts === undefined || isFetchingOutput ? ( <Fetching /> @@ -236,12 +232,7 @@ class BuildPage extends React.Component { return ( <> <PageSection variant={PageSectionVariants.light}> - <Build - build={build} - active={activeTab} - hash={hash} - fetchable={fetchable} - /> + <Build build={build} active={activeTab} hash={hash} /> </PageSection> <PageSection variant={PageSectionVariants.light}> <Tabs diff --git a/web/src/pages/Buildset.jsx b/web/src/pages/Buildset.jsx index 55e3e9cf9..b19aefb81 100644 --- a/web/src/pages/Buildset.jsx +++ b/web/src/pages/Buildset.jsx @@ -27,7 +27,7 @@ import { BuildIcon } from '@patternfly/react-icons' import { fetchBuildset } from '../actions/build' import { EmptyPage } from '../containers/Errors' -import { Fetchable, Fetching } from '../containers/Fetching' +import { Fetching } from '../containers/Fetching' import BuildList from '../containers/build/BuildList' import Buildset from '../containers/build/Buildset' @@ -103,14 +103,10 @@ class BuildsetPage extends React.Component { </> ) - const fetchable = ( - <Fetchable isFetching={isFetching} fetchCallback={this.updateData} /> - ) - return ( <> <PageSection variant={PageSectionVariants.light}> - <Buildset buildset={buildset} fetchable={fetchable} /> + <Buildset buildset={buildset} /> </PageSection> <PageSection variant={PageSectionVariants.light}> <Title headingLevel="h3"> |