diff options
author | Zuul <zuul@review.opendev.org> | 2023-04-26 17:49:02 +0000 |
---|---|---|
committer | Gerrit Code Review <review@openstack.org> | 2023-04-26 17:49:02 +0000 |
commit | c4a6f6fcd619e8882a74e24263c1f7c853400081 (patch) | |
tree | 709f22272de303f832db887be62e96dde399b27c /zuul/driver/gerrit/gerritsource.py | |
parent | aad1fe11a6d3da1c8b3eb6dbb97f35212b042643 (diff) | |
parent | 4e0da6221409d63124b2d8ba257df03209314a3d (diff) | |
download | zuul-c4a6f6fcd619e8882a74e24263c1f7c853400081.tar.gz |
Merge "Further fix getting topic changes by git needs"
Diffstat (limited to 'zuul/driver/gerrit/gerritsource.py')
-rw-r--r-- | zuul/driver/gerrit/gerritsource.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/zuul/driver/gerrit/gerritsource.py b/zuul/driver/gerrit/gerritsource.py index 3bf2b3a14..b0bd3c448 100644 --- a/zuul/driver/gerrit/gerritsource.py +++ b/zuul/driver/gerrit/gerritsource.py @@ -164,7 +164,9 @@ class GerritSource(BaseSource): change = self.connection._getChange(change_key) changes[change_key] = change - for change in changes.values(): + # Convert to list here because the recursive call can mutate + # the set. + for change in list(changes.values()): for git_change_ref in change.git_needs_changes: change_key = ChangeKey.fromReference(git_change_ref) if change_key in changes: |