diff options
author | Albin Vass <albin.vass@volvocars.com> | 2020-11-02 13:28:41 +0100 |
---|---|---|
committer | James E. Blair <jim@acmegating.com> | 2021-04-24 08:39:03 -0700 |
commit | c81c2c6eec85038d56e734ff9ce762c3da3c168f (patch) | |
tree | 082d4da679cfc88ec27cfd6af225009571b0c4fd /zuul/driver/gerrit/gerrittrigger.py | |
parent | 3ca33f0686437fc949ee2cedbf2fe13c9dc4ab3d (diff) | |
download | zuul-c81c2c6eec85038d56e734ff9ce762c3da3c168f.tar.gz |
Filter events on event connection
Currently if two triggers of the same connection type need to trigger on
different events it's not possible to do so since the events are never
filtered on which connection they came from.
For example with the following setup where gerrit-org-1 only wants to
trigger on changes to 'master' and gerrit-org-2 only wants to trigger on
changes to 'develop' they will instead both trigger on 'master' and
'develop'since the events are never filtered on which connection they
came from.
- pipeline:
name: check
trigger:
gerrit-org-1:
- event: patchset-created
branch: 'master'
gerrit-org-2:
- event: patchset-created
branch: 'develop'
Change-Id: Ia0476d71dee59c8b80db7630ac7a524bce87e6f9
Diffstat (limited to 'zuul/driver/gerrit/gerrittrigger.py')
-rw-r--r-- | zuul/driver/gerrit/gerrittrigger.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/zuul/driver/gerrit/gerrittrigger.py b/zuul/driver/gerrit/gerrittrigger.py index 88d198d32..196dbbf49 100644 --- a/zuul/driver/gerrit/gerrittrigger.py +++ b/zuul/driver/gerrit/gerrittrigger.py @@ -23,7 +23,7 @@ class GerritTrigger(BaseTrigger): name = 'gerrit' log = logging.getLogger("zuul.GerritTrigger") - def getEventFilters(self, trigger_conf): + def getEventFilters(self, connection_name, trigger_conf): efilters = [] for trigger in to_list(trigger_conf): approvals = {} @@ -42,6 +42,7 @@ class GerritTrigger(BaseTrigger): usernames = to_list(trigger.get('username_filter')) ignore_deletes = trigger.get('ignore-deletes', True) f = GerritEventFilter( + connection_name=connection_name, trigger=self, types=to_list(trigger['event']), branches=to_list(trigger.get('branch')), |