summaryrefslogtreecommitdiff
path: root/zuul/driver/github/githubmodel.py
diff options
context:
space:
mode:
authorSimon Westphahl <simon.westphahl@bmw.de>2020-09-23 11:01:56 +0200
committerSimon Westphahl <simon.westphahl@bmw.de>2020-09-23 10:04:41 +0000
commit784fa6c177d07cb4df8ce6f9a0dc3afe41e66975 (patch)
treec46d55fb4ec65709a3dc73d21e0a1b6e316dbb62 /zuul/driver/github/githubmodel.py
parent83281e33565dfe872c3b82bb4a80733971ff216e (diff)
downloadzuul-784fa6c177d07cb4df8ce6f9a0dc3afe41e66975.tar.gz
Move driver specific change status field to driver
The 'status' field is a driver specific field and should therefore be defined and initialized in the driver specific subclass of a change and not in the 'Change' base class. Change-Id: I0a20041ae8b9f5e4c359fea86c21d1c5c5cbfaca
Diffstat (limited to 'zuul/driver/github/githubmodel.py')
-rw-r--r--zuul/driver/github/githubmodel.py5
1 files changed, 0 insertions, 5 deletions
diff --git a/zuul/driver/github/githubmodel.py b/zuul/driver/github/githubmodel.py
index 8463d07f4..da06da46f 100644
--- a/zuul/driver/github/githubmodel.py
+++ b/zuul/driver/github/githubmodel.py
@@ -47,11 +47,6 @@ class PullRequest(Change):
def status(self):
return ["{}:{}:{}".format(*c) for c in self.contexts]
- @status.setter
- def status(self, value):
- # Dummy setter to ignore init to None in base class.
- pass
-
@property
def successful_contexts(self) -> set:
if not self.contexts: