diff options
author | James E. Blair <jim@acmegating.com> | 2023-01-04 15:28:38 -0800 |
---|---|---|
committer | James E. Blair <jim@acmegating.com> | 2023-01-04 15:33:49 -0800 |
commit | f82ef0882cbbbab468bf0b5551cdf91d715f0321 (patch) | |
tree | ea4d1b34dc103989f6cb0fb829c4450df7fc9343 /zuul/source/__init__.py | |
parent | d1f34d506aaecd30b599391a05813b57ded1fee0 (diff) | |
download | zuul-f82ef0882cbbbab468bf0b5551cdf91d715f0321.tar.gz |
Further avoid unnecessary change dependency updates
When adding a unit test for change I4fd6c0d4cf2839010ddf7105a7db12da06ef1074
I noticed that we were still querying the dependent change 4 times instead of
the expected 2. This was due to an indentation error which caused all 3
query retry attempts to execute.
This change corrects that and adds a unit test that covers this as well as
the previous optimization.
Change-Id: I798d8d713b8303abcebc32d5f9ccad84bd4a28b0
Diffstat (limited to 'zuul/source/__init__.py')
-rw-r--r-- | zuul/source/__init__.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/zuul/source/__init__.py b/zuul/source/__init__.py index dd11aa9b6..01a683b23 100644 --- a/zuul/source/__init__.py +++ b/zuul/source/__init__.py @@ -109,7 +109,7 @@ class BaseSource(object, metaclass=abc.ABCMeta): time.sleep(1) else: raise - return dep + return dep @abc.abstractmethod def getChangesDependingOn(self, change, projects, tenant): |