summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNiels van Adrichem <N.L.M.vanAdrichem@tudelft.nl>2014-10-07 15:04:13 +0000
committerBen Pfaff <blp@nicira.com>2014-10-07 12:38:33 -0700
commit3f5ce9ef37fe052c2f01d15f44996733920ce937 (patch)
treeb301790f55c3551ee3c05eb8e9ea750b1a7fed4b
parent154374a72b1065ca5de09fb8e8f9266eb9b5cc8b (diff)
downloadopenvswitch-3f5ce9ef37fe052c2f01d15f44996733920ce937.tar.gz
BFD: Decreasing minimal transmit and receive interval
I found the BFD transmit interval was lowerbounded by the default value without warning, although documentation does not consider a lowerbound. Testing has been performed with transmit and receive intervals as low as 1 ms, and although CPU overhead was effected (especially with multiple BFD sessions such as 6 and higher), it worked well. Signed-off-by: Niels van Adrichem <n.l.m.vanadrichem@tudelft.nl> Signed-off-by: Ben Pfaff <blp@nicira.com>
-rw-r--r--AUTHORS1
-rw-r--r--lib/bfd.c4
2 files changed, 3 insertions, 2 deletions
diff --git a/AUTHORS b/AUTHORS
index 518c10a1c..ab70d0bf4 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -262,6 +262,7 @@ Mike Kruze mkruze@nicira.com
Min Chen ustcer.tonychan@gmail.com
Mikael Doverhag mdoverhag@nicira.com
Nagi Reddy Jonnala njonnala@Brocade.com
+Niels van Adrichem N.L.M.vanAdrichem@tudelft.nl
Niklas Andersson nandersson@nicira.com
Pankaj Thakkar thakkar@nicira.com
Pasi Kärkkäinen pasik@iki.fi
diff --git a/lib/bfd.c b/lib/bfd.c
index 7884fc67e..7f6bf5b51 100644
--- a/lib/bfd.c
+++ b/lib/bfd.c
@@ -395,7 +395,7 @@ bfd_configure(struct bfd *bfd, const char *name, const struct smap *cfg,
atomic_store_relaxed(&bfd->check_tnl_key,
smap_get_bool(cfg, "check_tnl_key", false));
min_tx = smap_get_int(cfg, "min_tx", 100);
- min_tx = MAX(min_tx, 100);
+ min_tx = MAX(min_tx, 1);
if (bfd->cfg_min_tx != min_tx) {
bfd->cfg_min_tx = min_tx;
if (bfd->state != STATE_UP
@@ -406,7 +406,7 @@ bfd_configure(struct bfd *bfd, const char *name, const struct smap *cfg,
}
min_rx = smap_get_int(cfg, "min_rx", 1000);
- min_rx = MAX(min_rx, 100);
+ min_rx = MAX(min_rx, 1);
if (bfd->cfg_min_rx != min_rx) {
bfd->cfg_min_rx = min_rx;
if (bfd->state != STATE_UP