summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnand Kumar <kumaranand@vmware.com>2017-06-16 10:06:26 -0700
committerGurucharan Shetty <guru@ovn.org>2017-06-20 12:39:10 -0700
commit56c08ab4fae5a40e0b5f986b8bc1ff97b2dde3f3 (patch)
tree2218019dd633891067478dbc97d6f5717f4e4c9d
parentd0574c74df71ee16df5ea3dac374757187f250a8 (diff)
downloadopenvswitch-56c08ab4fae5a40e0b5f986b8bc1ff97b2dde3f3.tar.gz
windows: Remove vlog_init() from service_start function
When --syslog-method is passed as a cmd line argument and ovs daemons are started as a service, --syslog-method argument is not honoured, as vlog module is initialized by service_start function before parsing the command line arguments. Easy way to fix this, is to remove vlog_init() from the service start function and let the first log message to initialize the vlog module. Signed-off-by: Anand Kumar <kumaranand@vmware.com> Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Signed-off-by: Gurucharan Shetty <guru@ovn.org>
-rw-r--r--lib/daemon-windows.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/lib/daemon-windows.c b/lib/daemon-windows.c
index 580428454..1ba714dac 100644
--- a/lib/daemon-windows.c
+++ b/lib/daemon-windows.c
@@ -138,13 +138,6 @@ service_start(int *argcp, char **argvp[])
*argcp = sargc;
*argvp = *sargvp;
- /* XXX: Windows implementation cannot have a unixctl commands in the
- * traditional sense of unix domain sockets. If an implementation is
- * done that involves 'unixctl' vlog commands the following call is
- * needed to make sure that the unixctl commands for vlog get
- * registered in a daemon, even before the first log message. */
- vlog_init();
-
return;
}