diff options
| author | Eelco Chaudron <echaudro@redhat.com> | 2018-10-02 08:51:05 -0400 |
|---|---|---|
| committer | Ben Pfaff <blp@ovn.org> | 2018-10-02 15:29:47 -0700 |
| commit | 8826d8e0029a52a5dba2812d5345514cd3ddb62c (patch) | |
| tree | 47ebe270a155ff9f5e66b20b0aed820463797391 | |
| parent | 9443c4746b55c8220262942e8bdd0df8ddbc0e04 (diff) | |
| download | openvswitch-8826d8e0029a52a5dba2812d5345514cd3ddb62c.tar.gz | |
bridge: Fix ovs-appctl qos/show repeated queue information
The patch below would stop qos/show to repeat information from the previous queues.
See below an example before and after the fix:
Before:
$ ovs-appctl qos/show p5p2
QoS: p5p2 linux-htb
max-rate: 2428800
Default:
burst: 12512
min-rate: 12000
max-rate: 2428800
tx_packets: 0
tx_bytes: 0
tx_errors: 0
Queue 20:
burst: 12512
burst: 12512
min-rate: 12000
min-rate: 12000
max-rate: 607200
max-rate: 2428800
tx_packets: 28780
tx_bytes: 43572920
tx_errors: 17611
Queue 10:
burst: 12512
burst: 12512
burst: 12512
max-rate: 2428800
max-rate: 607200
max-rate: 2428800
min-rate: 12000
min-rate: 12000
min-rate: 12000
tx_packets: 71751
tx_bytes: 108631014
tx_errors: 18503
After:
$ ovs-appctl qos/show p5p2
QoS: p5p2 linux-htb
max-rate: 2428800
Default:
burst: 12512
min-rate: 12000
max-rate: 2428800
tx_packets: 0
tx_bytes: 0
tx_errors: 0
Queue 20:
burst: 12512
min-rate: 12000
max-rate: 607200
tx_packets: 28780
tx_bytes: 43572920
tx_errors: 17611
Queue 10:
burst: 12512
min-rate: 12000
max-rate: 2428800
tx_packets: 71751
tx_bytes: 108631014
tx_errors: 18503
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
| -rw-r--r-- | vswitchd/bridge.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 4b4fd8452..de55ba6df 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -3171,6 +3171,7 @@ qos_unixctl_show(struct unixctl_conn *conn, int argc OVS_UNUSED, smap_init(&details); NETDEV_QUEUE_FOR_EACH (&queue_id, &details, &dump, iface->netdev) { qos_unixctl_show_queue(queue_id, &details, iface, &ds); + smap_clear(&details); } smap_destroy(&details); |