summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaolo Valerio <pvalerio@redhat.com>2021-12-27 14:27:30 +0100
committerIlya Maximets <i.maximets@ovn.org>2022-02-14 21:38:02 +0100
commit989895501c53468569064e060f15bba3fc8f0cac (patch)
tree1b6f4b7e3698d7aa83b51e7d2c820dae06ba8d77
parente969370d300e3107ec4b74c04de1d466391b29ce (diff)
downloadopenvswitch-989895501c53468569064e060f15bba3fc8f0cac.tar.gz
system-traffic.at: Avoid sporadic failures during conntrack IPv6 HTTP/FTP tests.
Some sporadic false positive may be visible for the following tests: - conntrack - IPv6 HTTP - conntrack - FTP over IPv6 The failures show up randomly. The reason appears to be source address used when performing the request using wget: -tcp,orig=(src=fc00::1,dst=fc00::2,sport=<cleared>,dport=<cleared>),\ reply=(src=fc00::2,dst=fc00::1,sport=<cleared>,dport=<cleared>),\ protoinfo=(state=<cleared>) +tcp,orig=(src=fe80::f0eb:f8ff:fef0:138f,dst=fc00::2,sport=<cleared>,dport=<cleared>),\ reply=(src=fc00::2,dst=fe80::f0eb:f8ff:fef0:138f,sport=<cleared>,dport=<cleared>),\ protoinfo=(state=<cleared>) It seems that the problem can be addressed in multiple ways, but using "nodad" seems to be safe enough to fix the issue that now, after hundreds of attempts, is no longer present. Signed-off-by: Paolo Valerio <pvalerio@redhat.com> Acked-by: Mike Pattrick <mkp@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
-rw-r--r--tests/system-traffic.at13
1 files changed, 7 insertions, 6 deletions
diff --git a/tests/system-traffic.at b/tests/system-traffic.at
index c41e5fd15..f22d86e46 100644
--- a/tests/system-traffic.at
+++ b/tests/system-traffic.at
@@ -4161,8 +4161,8 @@ OVS_TRAFFIC_VSWITCHD_START()
ADD_NAMESPACES(at_ns0, at_ns1)
-ADD_VETH(p0, at_ns0, br0, "fc00::1/96")
-ADD_VETH(p1, at_ns1, br0, "fc00::2/96")
+ADD_VETH(p0, at_ns0, br0, "fc00::1/96", [], [], "nodad")
+ADD_VETH(p1, at_ns1, br0, "fc00::2/96", [], [], "nodad")
dnl Allow any traffic from ns0->ns1. Only allow nd, return traffic from ns1->ns0.
AT_DATA([flows.txt], [dnl
@@ -4185,6 +4185,7 @@ OVS_START_L7([at_ns1], [http6])
dnl HTTP requests from ns0->ns1 should work fine.
NS_CHECK_EXEC([at_ns0], [wget http://[[fc00::2]] -t 3 -T 1 --retry-connrefused -v -o wget0.log])
+
AT_CHECK([ovs-appctl dpctl/dump-conntrack | FORMAT_CT(fc00::2)], [0], [dnl
tcp,orig=(src=fc00::1,dst=fc00::2,sport=<cleared>,dport=<cleared>),reply=(src=fc00::2,dst=fc00::1,sport=<cleared>,dport=<cleared>),protoinfo=(state=<cleared>)
])
@@ -4588,8 +4589,8 @@ OVS_TRAFFIC_VSWITCHD_START()
ADD_NAMESPACES(at_ns0, at_ns1)
-ADD_VETH(p0, at_ns0, br0, "fc00::1/96")
-ADD_VETH(p1, at_ns1, br0, "fc00::2/96")
+ADD_VETH(p0, at_ns0, br0, "fc00::1/96", [], [], "nodad")
+ADD_VETH(p1, at_ns1, br0, "fc00::2/96", [], [], "nodad")
dnl Allow any traffic from ns0->ns1.
dnl Only allow nd, return traffic from ns1->ns0.
@@ -4643,9 +4644,9 @@ OVS_TRAFFIC_VSWITCHD_START()
ADD_NAMESPACES(at_ns0, at_ns1)
-ADD_VETH(p0, at_ns0, br0, "fc00::1/96")
+ADD_VETH(p0, at_ns0, br0, "fc00::1/96", [], [], "nodad")
NS_CHECK_EXEC([at_ns0], [ip link set dev p0 address 80:88:88:88:88:88])
-ADD_VETH(p1, at_ns1, br0, "fc00::2/96")
+ADD_VETH(p1, at_ns1, br0, "fc00::2/96", [], [], "nodad")
NS_CHECK_EXEC([at_ns1], [ip link set dev p1 address 80:88:88:88:88:99])
NS_CHECK_EXEC([at_ns0], [ip -6 neigh add fc00::2 lladdr 80:88:88:88:88:99 dev p0])
NS_CHECK_EXEC([at_ns1], [ip -6 neigh add fc00::1 lladdr 80:88:88:88:88:88 dev p1])