summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXiaoXiong Ding <dingxiaoxiong@huawei.com>2020-09-30 14:44:00 +0800
committerIlya Maximets <i.maximets@ovn.org>2020-12-21 18:48:19 +0100
commit9c433ab49413bd692a7ee251e19d16f08bed6f55 (patch)
treeb4991ddadf799775055da33c8ded3b6b70a045be
parent0dc0ceeb7d5049d215b37c6132f9d8f414c05d0d (diff)
downloadopenvswitch-9c433ab49413bd692a7ee251e19d16f08bed6f55.tar.gz
ofproto-dpif-xlate: Stop forwarding MLD reports to group ports.
According with rfc4541 section 2.1.1, a snooping switch should forward membership reports only to ports with routers attached.The current code violates the RFC forwarding membership reports to group ports as well. The same issue doesn't exist with IPv4. Fixes: 06994f879c ("mcast-snooping: Add Multicast Listener Discovery support") Signed-off-by: XiaoXiong Ding <dingxiaoxiong@huawei.com> Acked-by: Flavio Leitner <fbl@sysclose.org> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
-rw-r--r--ofproto/ofproto-dpif-xlate.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index 3aba4b221..fc7a126ed 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -2607,6 +2607,7 @@ xlate_normal(struct xlate_ctx *ctx)
xlate_report(ctx, OFT_DETAIL, "MLD query, flooding");
xlate_normal_flood(ctx, in_xbundle, vlan);
}
+ return;
} else {
if (is_ip_local_multicast(flow, wc)) {
/* RFC4541: section 2.1.2, item 2: Packets with a dst IP