summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBen Pfaff <blp@ovn.org>2018-07-27 11:14:44 -0700
committerIan Stokes <ian.stokes@intel.com>2018-08-08 22:06:21 +0100
commitb2d9a9ef5aae1b899e8458c5324e85ff70f27c7e (patch)
tree5f6b99b0073d29dcb87fa30fb57239b1e379c7e3
parent7333c3b1ce02148c7e6c584edeeb505277fe1b7f (diff)
downloadopenvswitch-b2d9a9ef5aae1b899e8458c5324e85ff70f27c7e.tar.gz
ofp-port: Drop of useless indirection in ofputil_pull_ofp14_port_stats().
Signed-off-by: Ben Pfaff <blp@ovn.org> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
-rw-r--r--lib/ofp-port.c30
1 files changed, 2 insertions, 28 deletions
diff --git a/lib/ofp-port.c b/lib/ofp-port.c
index 1d864c3a3..2c812f8ec 100644
--- a/lib/ofp-port.c
+++ b/lib/ofp-port.c
@@ -1637,28 +1637,6 @@ parse_intel_port_custom_property(struct ofpbuf *payload,
}
static enum ofperr
-parse_intel_port_stats_property(struct ofpbuf *payload,
- uint32_t exp_type,
- struct ofputil_port_stats *ops)
-{
- enum ofperr error;
-
- switch (exp_type) {
- case INTEL_PORT_STATS_RFC2819:
- error = parse_intel_port_stats_rfc2819_property(payload, ops);
- break;
- case INTEL_PORT_STATS_CUSTOM:
- error = parse_intel_port_custom_property(payload, ops);
- break;
- default:
- error = OFPERR_OFPBPC_BAD_EXP_TYPE;
- break;
- }
-
- return error;
-}
-
-static enum ofperr
ofputil_pull_ofp14_port_stats(struct ofputil_port_stats *ops,
struct ofpbuf *msg)
{
@@ -1705,14 +1683,10 @@ ofputil_pull_ofp14_port_stats(struct ofputil_port_stats *ops,
error = parse_ofp14_port_stats_ethernet_property(&payload, ops);
break;
case OFPPROP_EXP(INTEL_VENDOR_ID, INTEL_PORT_STATS_RFC2819):
- error = parse_intel_port_stats_property(&payload,
- INTEL_PORT_STATS_RFC2819,
- ops);
+ error = parse_intel_port_stats_rfc2819_property(&payload, ops);
break;
case OFPPROP_EXP(INTEL_VENDOR_ID, INTEL_PORT_STATS_CUSTOM):
- error = parse_intel_port_stats_property(&payload,
- INTEL_PORT_STATS_CUSTOM,
- ops);
+ error = parse_intel_port_custom_property(&payload, ops);
break;
default:
error = OFPPROP_UNKNOWN(true, "port stats", type);