diff options
| author | Ben Pfaff <blp@nicira.com> | 2014-06-25 13:58:41 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2014-06-25 13:58:41 -0700 |
| commit | 49ab4a352480af0be1251fe77337f9280c5a1198 (patch) | |
| tree | 5c5246ec80654e0a14977c0bfaf0dc448c297f7b /CodingStyle | |
| parent | 5715de1400dd1fafe7d3d08a02c6ca0a0cd998e9 (diff) | |
| download | openvswitch-49ab4a352480af0be1251fe77337f9280c5a1198.tar.gz | |
CodingStyle: Functions in .c files should usually not be marked "inline".
I thought this was in here already, but I guess not.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Alex Wang <alexw@nicira.com>
Diffstat (limited to 'CodingStyle')
| -rw-r--r-- | CodingStyle | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/CodingStyle b/CodingStyle index 0ba036697..628f21f83 100644 --- a/CodingStyle +++ b/CodingStyle @@ -162,6 +162,11 @@ such a function (including the C standard library function free()) should omit a null-pointer check. We find that this usually makes code easier to read. +Functions in .c files should not normally be marked "inline", because +it does not usually help code generation and it does suppress +compilers warnings about unused functions. (Functions defined in .h +usually should be marked inline.) + FUNCTION PROTOTYPES |