diff options
| author | Alin Serdean <aserdean@cloudbasesolutions.com> | 2016-12-08 18:44:50 +0000 |
|---|---|---|
| committer | Gurucharan Shetty <guru@ovn.org> | 2016-12-13 10:46:54 -0800 |
| commit | 50b0a1694520284f19884d17ed52a03f6ce239bb (patch) | |
| tree | 95df73621f5b14c399615164afbc2d71fb0b10e9 /datapath-windows/ovsext/Conntrack-tcp.c | |
| parent | bf71b09b48f5159737adc7b93129641d93715510 (diff) | |
| download | openvswitch-50b0a1694520284f19884d17ed52a03f6ce239bb.tar.gz | |
datapath-windows: Conntrack move null checks to functions
Add null checks inside OvsConntrackValidateIcmpPacket,
OvsConntrackValidateTcpPacket to make the functions self-contained.
Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Suggested-by: Yin Lin <linyi@vmware.com>
Acked-by: Sairam Venugopal <vsairam@vmware.com>
Signed-off-by: Gurucharan Shetty <guru@ovn.org>
Diffstat (limited to 'datapath-windows/ovsext/Conntrack-tcp.c')
| -rw-r--r-- | datapath-windows/ovsext/Conntrack-tcp.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/datapath-windows/ovsext/Conntrack-tcp.c b/datapath-windows/ovsext/Conntrack-tcp.c index c7fcfa8ff..1c46bb015 100644 --- a/datapath-windows/ovsext/Conntrack-tcp.c +++ b/datapath-windows/ovsext/Conntrack-tcp.c @@ -457,9 +457,13 @@ OvsConntrackUpdateTcpEntry(OVS_CT_ENTRY* conn_, BOOLEAN OvsConntrackValidateTcpPacket(const TCPHdr *tcp) { + if (!tcp) { + return FALSE; + } + UINT16 tcp_flags = ntohs(tcp->flags); - if (tcp == NULL || OvsCtInvalidTcpFlags(tcp_flags)) { + if (OvsCtInvalidTcpFlags(tcp_flags)) { return FALSE; } |