diff options
| author | Alin Serdean <aserdean@cloudbasesolutions.com> | 2016-11-28 14:07:09 +0000 |
|---|---|---|
| committer | Gurucharan Shetty <guru@ovn.org> | 2016-11-29 10:38:33 -0800 |
| commit | 34a2010c83a6fc0d02fd3ab138961a41e56c8718 (patch) | |
| tree | 15f2bd7373a832d0ca260a4c734f37b104c1acf3 /datapath-windows/ovsext/Conntrack.c | |
| parent | fb7c468b5c2f87f434edcec150498cc50b17b6a5 (diff) | |
| download | openvswitch-34a2010c83a6fc0d02fd3ab138961a41e56c8718.tar.gz | |
datapath-windows: fix return value in conntrack
'status' is of type 'NTSTATUS' and NlFillOvsMsgForNfGenMsg is of type bool.
Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Acked-by: Sairam Venugopal <vsairam@vmware.com>
Signed-off-by: Gurucharan Shetty <guru@ovn.org>
Diffstat (limited to 'datapath-windows/ovsext/Conntrack.c')
| -rw-r--r-- | datapath-windows/ovsext/Conntrack.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-windows/ovsext/Conntrack.c index b0846f6fc..e663c3b1d 100644 --- a/datapath-windows/ovsext/Conntrack.c +++ b/datapath-windows/ovsext/Conntrack.c @@ -802,12 +802,14 @@ OvsCtDeleteCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx, NlBufInit(&nlBuf, usrParamsCtx->outputBuffer, usrParamsCtx->outputLength); - status = NlFillOvsMsgForNfGenMsg(&nlBuf, nlmsgType, NLM_F_CREATE, - msgIn->nlMsg.nlmsgSeq, - msgIn->nlMsg.nlmsgPid, - AF_UNSPEC, - msgIn->nfGenMsg.version, - 0); + if (!NlFillOvsMsgForNfGenMsg(&nlBuf, nlmsgType, NLM_F_CREATE, + msgIn->nlMsg.nlmsgSeq, + msgIn->nlMsg.nlmsgPid, + AF_UNSPEC, + msgIn->nfGenMsg.version, + 0)) { + status = STATUS_INVALID_PARAMETER; + } nlMsg = (PNL_MSG_HDR)NlBufAt(&nlBuf, 0, 0); nlMsg->nlmsgLen = NlBufSize(&nlBuf); *replyLen = msgOut->nlMsg.nlmsgLen; |