diff options
| author | Alin Serdean <aserdean@cloudbasesolutions.com> | 2016-12-08 18:44:50 +0000 |
|---|---|---|
| committer | Gurucharan Shetty <guru@ovn.org> | 2016-12-13 10:46:54 -0800 |
| commit | 50b0a1694520284f19884d17ed52a03f6ce239bb (patch) | |
| tree | 95df73621f5b14c399615164afbc2d71fb0b10e9 /datapath-windows/ovsext/Conntrack.c | |
| parent | bf71b09b48f5159737adc7b93129641d93715510 (diff) | |
| download | openvswitch-50b0a1694520284f19884d17ed52a03f6ce239bb.tar.gz | |
datapath-windows: Conntrack move null checks to functions
Add null checks inside OvsConntrackValidateIcmpPacket,
OvsConntrackValidateTcpPacket to make the functions self-contained.
Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Suggested-by: Yin Lin <linyi@vmware.com>
Acked-by: Sairam Venugopal <vsairam@vmware.com>
Signed-off-by: Gurucharan Shetty <guru@ovn.org>
Diffstat (limited to 'datapath-windows/ovsext/Conntrack.c')
| -rw-r--r-- | datapath-windows/ovsext/Conntrack.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/datapath-windows/ovsext/Conntrack.c b/datapath-windows/ovsext/Conntrack.c index 84c409194..47dba9dc8 100644 --- a/datapath-windows/ovsext/Conntrack.c +++ b/datapath-windows/ovsext/Conntrack.c @@ -199,7 +199,7 @@ OvsCtEntryCreate(PNET_BUFFER_LIST curNbl, TCPHdr tcpStorage; const TCPHdr *tcp; tcp = OvsGetTcp(curNbl, l4Offset, &tcpStorage); - if (!tcp || !OvsConntrackValidateTcpPacket(tcp)) { + if (!OvsConntrackValidateTcpPacket(tcp)) { goto invalid; } @@ -220,7 +220,7 @@ OvsCtEntryCreate(PNET_BUFFER_LIST curNbl, ICMPHdr storage; const ICMPHdr *icmp; icmp = OvsGetIcmp(curNbl, l4Offset, &storage); - if (!icmp || !OvsConntrackValidateIcmpPacket(icmp)) { + if (!OvsConntrackValidateIcmpPacket(icmp)) { goto invalid; } |