diff options
| author | Sorin Vinturis <svinturis@cloudbasesolutions.com> | 2015-05-27 17:08:00 +0000 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2015-05-27 12:46:05 -0700 |
| commit | 8909c56c467881236b655e5c4f4c5caa63178cd5 (patch) | |
| tree | 49994aa5a05060439357e81ff785c2883485a36a /datapath-windows/ovsext/Datapath.c | |
| parent | 68f1df92ce8dab00bbd3bf46819a758e1d193dcf (diff) | |
| download | openvswitch-8909c56c467881236b655e5c4f4c5caa63178cd5.tar.gz | |
datapath-windows: Removed memory barrier and master lock
There is no need to enforce Netlink serialization on transactions
sent from userspace. The access to the driver's shared resources
is synchronized anyway. Thus I have removed the master lock.
I also removed the memory barrier from filter dispatch routine. A
memory barrier is already in place in OvsReleaseSwitchContext
function, due to the use of InterlockedCompareExchange function.
Signed-off-by: Sorin Vinturis <svinturis@cloudbasesolutions.com>
Acked-by: Eitan Eliahu <eliahue@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Diffstat (limited to 'datapath-windows/ovsext/Datapath.c')
| -rw-r--r-- | datapath-windows/ovsext/Datapath.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c index 185bfb53c..b5832de3b 100644 --- a/datapath-windows/ovsext/Datapath.c +++ b/datapath-windows/ovsext/Datapath.c @@ -726,12 +726,6 @@ OvsDeviceControl(PDEVICE_OBJECT deviceObject, goto exit; } - /* Concurrent netlink operations are not supported. */ - if (InterlockedCompareExchange((LONG volatile *)&instance->inUse, 1, 0)) { - status = STATUS_RESOURCE_IN_USE; - goto done; - } - /* * Validate the input/output buffer arguments depending on the type of the * operation. @@ -921,9 +915,6 @@ done: OvsReleaseSwitchContext(gOvsSwitchContext); exit: - KeMemoryBarrier(); - instance->inUse = 0; - /* Should not complete a pending IRP unless proceesing is completed. */ if (status == STATUS_PENDING) { /* STATUS_PENDING is returned by the NL handler when the request is |