summaryrefslogtreecommitdiff
path: root/datapath-windows/ovsext/Flow.c
diff options
context:
space:
mode:
authorAlin Serdean <aserdean@cloudbasesolutions.com>2016-03-31 09:16:51 +0000
committerBen Pfaff <blp@ovn.org>2016-03-31 08:19:05 -0700
commit7159d9c53d30cdad62ecca481009281983a615a9 (patch)
tree0277352f1b890739469c7077a7b896671a778b8c /datapath-windows/ovsext/Flow.c
parentf48e869e6077fb023ad10eccf68d718b3ba0e9f0 (diff)
downloadopenvswitch-7159d9c53d30cdad62ecca481009281983a615a9.tar.gz
datapath-windows: Fix OVS_KEY_ATTR_ICMPV6 support
This patch applies the conversions needed for the ICMPv6 type and code. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Acked-by: Sorin Vinturis <svinturis@cloudbasesolutions.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'datapath-windows/ovsext/Flow.c')
-rw-r--r--datapath-windows/ovsext/Flow.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index 02c41b700..b9623b11d 100644
--- a/datapath-windows/ovsext/Flow.c
+++ b/datapath-windows/ovsext/Flow.c
@@ -1162,9 +1162,8 @@ _MapFlowIpv6KeyToNlKey(PNL_BUFFER nlBuf, Ipv6Key *ipv6FlowPutKey,
struct ovs_key_icmpv6 icmpV6Key;
struct ovs_key_nd ndKey;
- /* XXX: revisit to see if htons is needed */
- icmpV6Key.icmpv6_type = (__u8)(icmpv6FlowPutKey->l4.tpSrc);
- icmpV6Key.icmpv6_code = (__u8)(icmpv6FlowPutKey->l4.tpDst);
+ icmpV6Key.icmpv6_type = (__u8)ntohs(icmpv6FlowPutKey->l4.tpSrc);
+ icmpV6Key.icmpv6_code = (__u8)ntohs(icmpv6FlowPutKey->l4.tpDst);
if (!NlMsgPutTailUnspec(nlBuf, OVS_KEY_ATTR_ICMPV6,
(PCHAR)(&icmpV6Key),
@@ -1504,8 +1503,8 @@ _MapKeyAttrToFlowPut(PNL_ATTR *keyAttrs,
icmpv6Key = NlAttrGet(keyAttrs[OVS_KEY_ATTR_ICMPV6]);
- icmp6FlowPutKey->l4.tpSrc = icmpv6Key->icmpv6_type;
- icmp6FlowPutKey->l4.tpDst = icmpv6Key->icmpv6_code;
+ icmp6FlowPutKey->l4.tpSrc = htons(icmpv6Key->icmpv6_type);
+ icmp6FlowPutKey->l4.tpDst = htons(icmpv6Key->icmpv6_code);
if (keyAttrs[OVS_KEY_ATTR_ND]) {
const struct ovs_key_nd *ndKey;