diff options
| author | Nithin Raju <nithin@vmware.com> | 2014-10-21 16:10:36 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2014-10-22 08:59:42 -0700 |
| commit | 7e6f1bab07de5b2eeaf2ce602ba9d5368d0ba7a6 (patch) | |
| tree | 13356777429e8001a6aa99d4c1b6a4d61f0b1963 /datapath-windows/ovsext/Flow.c | |
| parent | 3bd0fd39ebeaca5f87284704e7606d225d0e1bbb (diff) | |
| download | openvswitch-7e6f1bab07de5b2eeaf2ce602ba9d5368d0ba7a6.tar.gz | |
datapath-windows: Return success when duplicate flow is added.
If we are trying to insert a flow while there's already a key with the
same flow, return success instead of failure. It can be argued that we
should probably return a transactional error EEXIST, but we'll handle
this in a subsequent commit. I've added a comment to address this later.
Signed-off-by: Nithin Raju <nithin@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Eitan Eliahu <eliahue@vmware.com>
Diffstat (limited to 'datapath-windows/ovsext/Flow.c')
| -rw-r--r-- | datapath-windows/ovsext/Flow.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c index bc9ef874c..14c3072fb 100644 --- a/datapath-windows/ovsext/Flow.c +++ b/datapath-windows/ovsext/Flow.c @@ -2255,7 +2255,9 @@ HandleFlowPut(OvsFlowPut *put, RemoveFlow(datapath, &KernelFlow); } } else { - return STATUS_UNSUCCESSFUL; + /* Return success if an identical flow already exists. */ + /* XXX: should we return EEXIST in a netlink error? */ + return STATUS_SUCCESS; } } } |