diff options
| author | Nithin Raju <nithin@vmware.com> | 2014-12-08 09:43:13 -0800 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2014-12-11 16:43:52 -0800 |
| commit | 1ad44ad455e4f2f96eb98d8b3faf06f3e358c214 (patch) | |
| tree | 20a654a087513ec6c4e46809920aa2c5d0879c03 /datapath-windows/ovsext/Netlink | |
| parent | 5fc8ea2d6f0e604cad53e48164d64f0edcf43204 (diff) | |
| download | openvswitch-1ad44ad455e4f2f96eb98d8b3faf06f3e358c214.tar.gz | |
datapath-windows: return bool from NlFillOvs[Msg/Hdr]
Per review comment, in this patch, we update the return values of
NlFillOvsMsg() and NlFillOvsHdr() from NTSTATUS to BOOLEAN to make them
consistent with the Nl* functions.
Signed-off-by: Nithin Raju <nithin@vmware.com>
Acked-by: Eitan Eliahu <eliahue@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Diffstat (limited to 'datapath-windows/ovsext/Netlink')
| -rw-r--r-- | datapath-windows/ovsext/Netlink/Netlink.c | 8 | ||||
| -rw-r--r-- | datapath-windows/ovsext/Netlink/Netlink.h | 12 |
2 files changed, 10 insertions, 10 deletions
diff --git a/datapath-windows/ovsext/Netlink/Netlink.c b/datapath-windows/ovsext/Netlink/Netlink.c index 0d48d081d..589e3a1f3 100644 --- a/datapath-windows/ovsext/Netlink/Netlink.c +++ b/datapath-windows/ovsext/Netlink/Netlink.c @@ -39,7 +39,7 @@ * Attributes should be added by caller. * --------------------------------------------------------------------------- */ -NTSTATUS +BOOLEAN NlFillOvsMsg(PNL_BUFFER nlBuf, UINT16 nlmsgType, UINT16 nlmsgFlags, UINT32 nlmsgSeq, UINT32 nlmsgPid, UINT8 genlCmd, @@ -68,7 +68,7 @@ NlFillOvsMsg(PNL_BUFFER nlBuf, UINT16 nlmsgType, writeOk = NlMsgPutTail(nlBuf, (PCHAR)(&msgOut), sizeof (struct _OVS_MESSAGE)); - return writeOk ? STATUS_SUCCESS : STATUS_INVALID_BUFFER_SIZE; + return writeOk; } /* @@ -77,7 +77,7 @@ NlFillOvsMsg(PNL_BUFFER nlBuf, UINT16 nlmsgType, * input NlBuf. * --------------------------------------------------------------------------- */ -NTSTATUS +BOOLEAN NlFillNlHdr(PNL_BUFFER nlBuf, UINT16 nlmsgType, UINT16 nlmsgFlags, UINT32 nlmsgSeq, UINT32 nlmsgPid) @@ -99,7 +99,7 @@ NlFillNlHdr(PNL_BUFFER nlBuf, UINT16 nlmsgType, writeOk = NlMsgPutTail(nlBuf, (PCHAR)(&msgOut), sizeof(struct _NL_MSG_HDR)); - return writeOk ? STATUS_SUCCESS : STATUS_INVALID_BUFFER_SIZE; + return writeOk; } /* diff --git a/datapath-windows/ovsext/Netlink/Netlink.h b/datapath-windows/ovsext/Netlink/Netlink.h index a7a53e005..36ffee9bb 100644 --- a/datapath-windows/ovsext/Netlink/Netlink.h +++ b/datapath-windows/ovsext/Netlink/Netlink.h @@ -86,13 +86,13 @@ typedef struct _NL_POLICY #define NL_ATTR_GET_AS(NLA, TYPE) \ (*(TYPE*) NlAttrGetUnspec(nla, sizeof(TYPE))) -NTSTATUS NlFillOvsMsg(PNL_BUFFER nlBuf, - UINT16 nlmsgType, UINT16 nlmsgFlags, - UINT32 nlmsgSeq, UINT32 nlmsgPid, - UINT8 genlCmd, UINT8 genlVer, UINT32 dpNo); -NTSTATUS NlFillNlHdr(PNL_BUFFER nlBuf, +BOOLEAN NlFillOvsMsg(PNL_BUFFER nlBuf, UINT16 nlmsgType, UINT16 nlmsgFlags, - UINT32 nlmsgSeq, UINT32 nlmsgPid); + UINT32 nlmsgSeq, UINT32 nlmsgPid, + UINT8 genlCmd, UINT8 genlVer, UINT32 dpNo); +BOOLEAN NlFillNlHdr(PNL_BUFFER nlBuf, + UINT16 nlmsgType, UINT16 nlmsgFlags, + UINT32 nlmsgSeq, UINT32 nlmsgPid); VOID NlBuildErrorMsg(POVS_MESSAGE msgIn, POVS_MESSAGE_ERROR msgOut, UINT errorCode); |