summaryrefslogtreecommitdiff
path: root/datapath-windows/ovsext/Netlink
diff options
context:
space:
mode:
authorNithin Raju <nithin@vmware.com>2014-09-15 11:38:01 -0700
committerBen Pfaff <blp@nicira.com>2014-09-16 21:33:01 -0700
commit884c477fa87ee42f46937160caa35f3f983fe35c (patch)
treef3be5601d299b8e6834c7aff66c1d462c909d42e /datapath-windows/ovsext/Netlink
parent5e2a670201c936e0a1f8257f4540654f8b8bfed2 (diff)
downloadopenvswitch-884c477fa87ee42f46937160caa35f3f983fe35c.tar.gz
datapath-windows: fix bug in NlBufCopyAtTailUninit
We should be returning value of tail before the increment and not after. Signed-off-by: Nithin Raju <nithin@vmware.com> Acked-by: Ankur Sharma <ankursharma@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
Diffstat (limited to 'datapath-windows/ovsext/Netlink')
-rw-r--r--datapath-windows/ovsext/Netlink/NetlinkBuf.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.c b/datapath-windows/ovsext/Netlink/NetlinkBuf.c
index ba10d8317..918bddd32 100644
--- a/datapath-windows/ovsext/Netlink/NetlinkBuf.c
+++ b/datapath-windows/ovsext/Netlink/NetlinkBuf.c
@@ -213,15 +213,13 @@ done:
PCHAR
NlBufCopyAtTailUninit(PNL_BUFFER nlBuf, UINT32 len)
{
- PCHAR ret = NULL;
+ PCHAR ret;
+ ret = nlBuf->tail;
if ((NlBufCopyAtTail(nlBuf, NULL, len)) == FALSE) {
- goto done;
+ ret = NULL;
}
- ret = nlBuf->tail;
-
-done:
return ret;
}