diff options
| author | Nithin Raju <nithin@vmware.com> | 2014-10-30 13:17:43 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@nicira.com> | 2014-10-31 13:54:52 -0700 |
| commit | 3bfe44a47d510980f8da4c81a8b6cf17d9dfeaf3 (patch) | |
| tree | c172102f19757f329a03b158357b7551d9791a67 /datapath-windows/ovsext/PacketIO.c | |
| parent | eb391b76aff9639547312ab93bdac9cc2e76c119 (diff) | |
| download | openvswitch-3bfe44a47d510980f8da4c81a8b6cf17d9dfeaf3.tar.gz | |
datapath-windows: Don't leak NBLs with multiple NBs.
Currently, if we receive an NBL with multiple NBs from NDIS, we just
ASSERT() and not do anything. The right thing to do obviously is to
process the NBL. This is a work in progress.
In the meantime, we should complete the NBL and not just leak it.
Signed-off-by: Nithin Raju <nithin@vmware.com>
Acked-by: Eitan Eliahu <eliahue@vmware.com>
Tested-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Diffstat (limited to 'datapath-windows/ovsext/PacketIO.c')
| -rw-r--r-- | datapath-windows/ovsext/PacketIO.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/datapath-windows/ovsext/PacketIO.c b/datapath-windows/ovsext/PacketIO.c index 52231259e..1af391b42 100644 --- a/datapath-windows/ovsext/PacketIO.c +++ b/datapath-windows/ovsext/PacketIO.c @@ -218,7 +218,12 @@ OvsStartNBLIngress(POVS_SWITCH_CONTEXT switchContext, curNb = NET_BUFFER_LIST_FIRST_NB(curNbl); if (curNb->Next != NULL) { /* XXX: This case is not handled yet. */ - ASSERT(FALSE); + RtlInitUnicodeString(&filterReason, + L"Dropping NBLs with multiple NBs"); + OvsStartNBLIngressError(switchContext, curNbl, + sendCompleteFlags, &filterReason, + NDIS_STATUS_RESOURCES); + continue; } else { POVS_BUFFER_CONTEXT ctx; OvsFlow *flow; |