diff options
| author | Nithin Raju <nithin@vmware.com> | 2015-11-25 12:16:30 -0800 |
|---|---|---|
| committer | Ben Pfaff <blp@ovn.org> | 2015-11-25 21:55:33 -0800 |
| commit | 09dbf169e129778d25e7e69a1d87d4e00cf34505 (patch) | |
| tree | f4bd2dc2497001149a933e22039be7bf3de65a20 /datapath-windows/ovsext/Util.h | |
| parent | bc06cc7659c6d7e9a854d1d5fee83e44ba35a409 (diff) | |
| download | openvswitch-09dbf169e129778d25e7e69a1d87d4e00cf34505.tar.gz | |
datapath-windows: fix MIN() macro
A quick implementation of MIN() didn't take into account operator
precedence as shown in the following example:
#include <stdio.h>
#define MYMIN(_a, _b) (_a) > (_b) ? (_b) : (_a)
int main() {
if (MYMIN(512, 256) < 14) {
printf("buggy MYMIN\n");
}
return 0;
}
Signed-off-by: Nithin Raju <nithin@vmware.com>
Acked-by: Russell Bryant <russell@ovn.org>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'datapath-windows/ovsext/Util.h')
| -rw-r--r-- | datapath-windows/ovsext/Util.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/datapath-windows/ovsext/Util.h b/datapath-windows/ovsext/Util.h index 0bbc52b31..e5ba72bd8 100644 --- a/datapath-windows/ovsext/Util.h +++ b/datapath-windows/ovsext/Util.h @@ -66,7 +66,7 @@ VOID OvsFreeAlignedMemory(VOID *ptr); VOID OvsAppendList(PLIST_ENTRY dst, PLIST_ENTRY src); -#define MIN(_a, _b) (_a) > (_b) ? (_b) : (_a) +#define MIN(_a, _b) ((_a) > (_b) ? (_b) : (_a)) #define ARRAY_SIZE(_x) ((sizeof(_x))/sizeof (_x)[0]) #define OVS_SWITCH_PORT_ID_INVALID (NDIS_SWITCH_PORT_ID)(-1) |