summaryrefslogtreecommitdiff
path: root/datapath-windows/ovsext/Vport.c
diff options
context:
space:
mode:
authorNithin Raju <nithin@vmware.com>2015-09-03 07:01:49 -0700
committerBen Pfaff <blp@nicira.com>2015-09-04 11:26:26 -0700
commitc42d0da69c41b54c99346d5c1769dd0b5b82a6f4 (patch)
tree003246c4e2db1c732428419b12484aa79a88db12 /datapath-windows/ovsext/Vport.c
parent25030d47665ecf1f46fba5abd404703df63df06d (diff)
downloadopenvswitch-c42d0da69c41b54c99346d5c1769dd0b5b82a6f4.tar.gz
datapath-windows: check vport attribute before access
OVS_VPORT_ATTR_OPTIONS being an optional attribute should be preceded by a check for valid value before access. Signed-off-by: Nithin Raju <nithin@vmware.com> Acked-by: Sairam Venugopal <vsairam@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
Diffstat (limited to 'datapath-windows/ovsext/Vport.c')
-rw-r--r--datapath-windows/ovsext/Vport.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c
index 6b74ec28c..dd615e4ac 100644
--- a/datapath-windows/ovsext/Vport.c
+++ b/datapath-windows/ovsext/Vport.c
@@ -2177,10 +2177,12 @@ OvsNewVportCmdHandler(POVS_USER_PARAMS_CONTEXT usrParamsCtx,
break;
}
- PNL_ATTR attr = NlAttrFindNested(vportAttrs[OVS_VPORT_ATTR_OPTIONS],
- OVS_TUNNEL_ATTR_DST_PORT);
- if (attr) {
- transportPortDest = NlAttrGetU16(attr);
+ if (vportAttrs[OVS_VPORT_ATTR_OPTIONS]) {
+ PNL_ATTR attr = NlAttrFindNested(vportAttrs[OVS_VPORT_ATTR_OPTIONS],
+ OVS_TUNNEL_ATTR_DST_PORT);
+ if (attr) {
+ transportPortDest = NlAttrGetU16(attr);
+ }
}
status = OvsInitTunnelVport(usrParamsCtx,