diff options
| author | Alin Serdean <aserdean@cloudbasesolutions.com> | 2017-05-23 17:59:06 +0000 |
|---|---|---|
| committer | Gurucharan Shetty <guru@ovn.org> | 2017-05-25 08:48:58 -0700 |
| commit | ad91a8e61c368fb13beb3a3100d84301fbf71dd4 (patch) | |
| tree | ec3d12ddc745d8929785c3409a2bd95234727c51 /datapath-windows | |
| parent | c0527566fc7db4d36a7d6dce8271c95104140963 (diff) | |
| download | openvswitch-ad91a8e61c368fb13beb3a3100d84301fbf71dd4.tar.gz | |
datapath-windows: Remove Strsafe usage from datapath
The removal is mandatory to use the VStudio 2013 static code analyzer.
The only function that was used from the include is: 'StringCbLengthA'.
We were not checking the result of that function, nor will the
'vportGet->name' exceed the 'OVS_MAX_PORT_NAME_LENGTH' limitation.
Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Acked-By: Anand Kumar <kumaranand@vmware.com>
Signed-off-by: Gurucharan Shetty <guru@ovn.org>
Diffstat (limited to 'datapath-windows')
| -rw-r--r-- | datapath-windows/ovsext/Netlink/NetlinkBuf.c | 1 | ||||
| -rw-r--r-- | datapath-windows/ovsext/Vport.c | 2 | ||||
| -rw-r--r-- | datapath-windows/ovsext/precomp.h | 1 |
3 files changed, 0 insertions, 4 deletions
diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.c b/datapath-windows/ovsext/Netlink/NetlinkBuf.c index 0177e8803..639b6e50d 100644 --- a/datapath-windows/ovsext/Netlink/NetlinkBuf.c +++ b/datapath-windows/ovsext/Netlink/NetlinkBuf.c @@ -40,7 +40,6 @@ #include <intsafe.h> #include <ntintsafe.h> #include <ntstrsafe.h> -#include <Strsafe.h> #ifdef OVS_DBG_MOD #undef OVS_DBG_MOD diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c index 914293750..075f4199a 100644 --- a/datapath-windows/ovsext/Vport.c +++ b/datapath-windows/ovsext/Vport.c @@ -1618,7 +1618,6 @@ OvsGetExtInfoIoctl(POVS_VPORT_GET vportGet, POVS_VPORT_EXT_INFO extInfo) { POVS_VPORT_ENTRY vport; - size_t len; LOCK_STATE_EX lockState; NTSTATUS status = STATUS_SUCCESS; BOOLEAN doConvert = FALSE; @@ -1626,7 +1625,6 @@ OvsGetExtInfoIoctl(POVS_VPORT_GET vportGet, RtlZeroMemory(extInfo, sizeof (POVS_VPORT_EXT_INFO)); NdisAcquireRWLockRead(gOvsSwitchContext->dispatchLock, &lockState, 0); if (vportGet->portNo == 0) { - StringCbLengthA(vportGet->name, OVS_MAX_PORT_NAME_LENGTH - 1, &len); vport = OvsFindVportByHvNameA(gOvsSwitchContext, vportGet->name); if (vport == NULL) { /* If the port is not a Hyper-V port and it has been added earlier, diff --git a/datapath-windows/ovsext/precomp.h b/datapath-windows/ovsext/precomp.h index a15258298..14f6843d3 100644 --- a/datapath-windows/ovsext/precomp.h +++ b/datapath-windows/ovsext/precomp.h @@ -19,7 +19,6 @@ #include <intsafe.h> #include <ntintsafe.h> #include <ntstrsafe.h> -#include <Strsafe.h> #include "Types.h" |