diff options
| author | Greg Rose <gvrose8192@gmail.com> | 2018-07-19 18:48:31 -0700 |
|---|---|---|
| committer | Ben Pfaff <blp@ovn.org> | 2018-07-27 11:35:54 -0700 |
| commit | 121905984724b409616f9b5af2d60ee460bbbdcf (patch) | |
| tree | 0534d18d82b73094e0061d24d7379de2d46dc52a /datapath/datapath.c | |
| parent | 494a74557a7d8eb8aafcc8a6e96ac3493356e033 (diff) | |
| download | openvswitch-121905984724b409616f9b5af2d60ee460bbbdcf.tar.gz | |
compat: Initialize IPv4 reassembly secret timer
The RHEL 7 kernels expect the secret timer interval to be initialized
before calling the inet_frags_init() function. By not initializing it
the inet_frags_secret_rebuild() function was running on every tick
rather than on the expected interval. This caused occasional panics
from page faults when inet_frags_secret_rebuild() would try to rearm a
timer from the openvswitch kernel module which had just been removed.
Also remove the prior, and now unnecessary, work around.
VMware BZ 2094203
Fixes: 595e069a ("compat: Backport IPv4 reassembly.")
Signed-off-by: Greg Rose <gvrose8192@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Yi-Hung Wei <yihung.wei@gmail.com>
Diffstat (limited to 'datapath/datapath.c')
| -rw-r--r-- | datapath/datapath.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/datapath/datapath.c b/datapath/datapath.c index 43f0d7432..3ea240adb 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -2478,16 +2478,6 @@ error: static void dp_cleanup(void) { -#if RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8,0) - /* On RHEL 7.x kernels we hit a kernel paging error without - * this barrier and subsequent hefty delay. A process will - * attempt to access openvwitch memory after it has been - * unloaded. Further debugging is needed on that but for - * now let's not let customer machines panic. - */ - rcu_barrier(); - msleep(3000); -#endif dp_unregister_genl(ARRAY_SIZE(dp_genl_families)); ovs_netdev_exit(); unregister_netdevice_notifier(&ovs_dp_device_notifier); |