diff options
| author | Pravin Shelar <pshelar@nicira.com> | 2011-09-09 19:09:47 -0700 |
|---|---|---|
| committer | Pravin Shelar <pshelar@nicira.com> | 2011-09-09 19:09:47 -0700 |
| commit | 3544358aa5960b148bc31435a0062e9392530ec2 (patch) | |
| tree | af87a0e875081e2222fefd6e92ad1deb55be2fc7 /datapath/vport-internal_dev.c | |
| parent | d9065a90b6b955aa38586c952e8804ca7a22547e (diff) | |
| download | openvswitch-3544358aa5960b148bc31435a0062e9392530ec2.tar.gz | |
datapath: Improve kernel hash table
Currently OVS uses its own hashing implmentation for hash tables
which has some problems, e.g. error case on deletion code.
Following patch replaces that with hlist based hash table which is
consistent with other kernel hash tables. As Jesse suggested, flex-array
is used for allocating hash buckets, So that we can have large
hash-table without large contiguous kernel memory.
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
Diffstat (limited to 'datapath/vport-internal_dev.c')
| -rw-r--r-- | datapath/vport-internal_dev.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c index f77763785..82079bd11 100644 --- a/datapath/vport-internal_dev.c +++ b/datapath/vport-internal_dev.c @@ -230,7 +230,7 @@ error: return ERR_PTR(err); } -static int internal_dev_destroy(struct vport *vport) +static void internal_dev_destroy(struct vport *vport) { struct netdev_vport *netdev_vport = netdev_vport_priv(vport); @@ -239,8 +239,6 @@ static int internal_dev_destroy(struct vport *vport) /* unregister_netdevice() waits for an RCU grace period. */ unregister_netdevice(netdev_vport->dev); - - return 0; } static int internal_dev_recv(struct vport *vport, struct sk_buff *skb) |