diff options
| author | Jiri Benc <jbenc@redhat.com> | 2017-05-02 19:20:03 -0700 |
|---|---|---|
| committer | Pravin B Shelar <pshelar@ovn.org> | 2017-05-04 23:16:54 -0700 |
| commit | 69ee22a47a64984ed0b964574f75634234af3744 (patch) | |
| tree | 4b3e93a5bf044bcb92245d7fdf29c0e884d9bfc8 /datapath | |
| parent | 86d46f3c1807d19faadba5e6c1c72acc2bb7017a (diff) | |
| download | openvswitch-69ee22a47a64984ed0b964574f75634234af3744.tar.gz | |
datapath: backport: vxlan: do not output confusing error message
Upstream commit:
commit baf4d7860771287f30fbe9b6b2dc18b04361439d
Author: Jiri Benc <jbenc@redhat.com>
Date: Thu Apr 27 21:24:36 2017 +0200
vxlan: do not output confusing error message
The message "Cannot bind port X, err=Y" creates only confusion. In metadata
based mode, failure of IPv6 socket creation is okay if IPv6 is disabled and
no error message should be printed. But when IPv6 tunnel was requested, such
failure is fatal. The vxlan_socket_create does not know when the error is
harmless and when it's not.
Instead of passing such information down to vxlan_socket_create, remove the
message completely. It's not useful. We propagate the error code up to the
user space and the port number comes from the user space. There's nothing in
the message that the process creating vxlan interface does not know.
Signed-off-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Pravin B Shelar <pshelar@ovn.org>
Acked-by: Joe Stringer <joe@ovn.org>
Diffstat (limited to 'datapath')
| -rw-r--r-- | datapath/linux/compat/vxlan.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/datapath/linux/compat/vxlan.c b/datapath/linux/compat/vxlan.c index 50126ec7e..d27a5e293 100644 --- a/datapath/linux/compat/vxlan.c +++ b/datapath/linux/compat/vxlan.c @@ -1740,8 +1740,6 @@ static struct vxlan_sock *vxlan_socket_create(struct net *net, bool ipv6, sock = vxlan_create_sock(net, ipv6, port, flags); if (IS_ERR(sock)) { - pr_info("Cannot bind port %d, err=%ld\n", ntohs(port), - PTR_ERR(sock)); kfree(vs); return ERR_CAST(sock); } |