diff options
| author | Jarno Rajahalme <jarno@ovn.org> | 2016-07-29 16:52:03 -0700 |
|---|---|---|
| committer | Jarno Rajahalme <jarno@ovn.org> | 2016-07-29 16:52:03 -0700 |
| commit | 362a2ebb5ba2c105930391ce931558a56474701b (patch) | |
| tree | 834ec2605597f2e0b3b44ee0edb37efb1645e703 /include/openvswitch/meta-flow.h | |
| parent | aff49b8c66beaf509f6d165164696c14bba4247f (diff) | |
| download | openvswitch-362a2ebb5ba2c105930391ce931558a56474701b.tar.gz | |
ofproto-dpif-xlate: Hash only fields specified for 'hash' selection method.
The mask for non-present fields in struct field_array is always zero,
so hashing a prerequisite field that was not also specified for the
"hash" selection method boiled down to hashing a all-zeroes value and
unwildcarding the prerequisite field. Now that mf_are_prereqs_ok()
already takes care of unwildcarding, we can simplify the code by
hashing only the specified fields.
Also change the test case to include fields that have prerequisities.
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Acked-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'include/openvswitch/meta-flow.h')
| -rw-r--r-- | include/openvswitch/meta-flow.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/openvswitch/meta-flow.h b/include/openvswitch/meta-flow.h index 10e1f771c..d8c5dd868 100644 --- a/include/openvswitch/meta-flow.h +++ b/include/openvswitch/meta-flow.h @@ -2062,8 +2062,6 @@ void mf_get_mask(const struct mf_field *, const struct flow_wildcards *, /* Prerequisites. */ bool mf_are_prereqs_ok(const struct mf_field *mf, const struct flow *flow, struct flow_wildcards *wc); -void mf_bitmap_set_field_and_prereqs(const struct mf_field *mf, struct - mf_bitmap *bm); static inline bool mf_is_l3_or_higher(const struct mf_field *mf) |