summaryrefslogtreecommitdiff
path: root/lib/dpif-netlink.c
diff options
context:
space:
mode:
authorIlya Maximets <i.maximets@ovn.org>2021-04-04 19:31:45 +0200
committerIlya Maximets <i.maximets@ovn.org>2021-05-24 20:21:56 +0200
commit328d20e0f8d0cfc8c80079784bff07219f687bf0 (patch)
tree55216eaaeaf45b9c4a2cf92816dd16b727bfc4bf /lib/dpif-netlink.c
parent577b9a8169b8c3ac417acf9b37443ca7dcebcf1c (diff)
downloadopenvswitch-328d20e0f8d0cfc8c80079784bff07219f687bf0.tar.gz
ofproto-dpif: Fix use of uninitialized attributes of timeout policy.
'cdtp' is allocated on a stack and it has uninitialized 'present' field that specifies which attributes are actually set. This causes use of uninitialized attributes. Conditional jump or move depends on uninitialised value(s) at 0x539651: dpif_netlink_get_nl_tp_udp_attrs (dpif-netlink.c:3206) by 0x539651: dpif_netlink_get_nl_tp_attrs (dpif-netlink.c:3234) by 0x539651: dpif_netlink_ct_set_timeout_policy (dpif-netlink.c:3370) by 0x42B615: ct_add_timeout_policy_to_dpif (ofproto-dpif.c:5421) by 0x42B615: ct_set_zone_timeout_policy (ofproto-dpif.c:5525) by 0x40BD98: ct_zones_reconfigure (bridge.c:756) by 0x40BD98: datapath_reconfigure (bridge.c:804) by 0x40D737: bridge_reconfigure (bridge.c:903) by 0x411720: bridge_run (bridge.c:3331) by 0x40751C: main (ovs-vswitchd.c:127) Clearing the whole structure to avoid this kind of problems. Fixes: 993cae678bca ("ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Acked-by: Mark D. Gray <mark.d.gray@redhat.com>
Diffstat (limited to 'lib/dpif-netlink.c')
0 files changed, 0 insertions, 0 deletions