summaryrefslogtreecommitdiff
path: root/lib/netdev.c
diff options
context:
space:
mode:
authorDaniel Alvarez <dalvarez@redhat.com>2018-11-16 11:42:29 +0100
committerBen Pfaff <blp@ovn.org>2018-12-12 10:49:05 -0800
commit3bdf8b620b44519cf30e0c8c8a6aed1c1ce93548 (patch)
treea6905fe4616fabeaecd5fa79a6233b6f1b3d1c00 /lib/netdev.c
parent8c3b84fb3956d3fc60aac649ce40c82376519d4e (diff)
downloadopenvswitch-3bdf8b620b44519cf30e0c8c8a6aed1c1ce93548.tar.gz
netdev: Add comment to allow removing a workaround in the future
This patch [0] in glibc fixes an issue which is right now workarounded in OVS by [1]. I'm adding a comment to indicate that from glibc 2.28 and beyond, the workaround is not needed so that we can eventually remove it. [0] https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c1f86a33ca32e26a9d6e29fc961e5ecb5e2e5eb4 [1] https://github.com/openvswitch/ovs/commit/3434d306866d825084d2d186d1f8dd98662ff650 Signed-off-by: Daniel Alvarez <dalvarez@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'lib/netdev.c')
-rw-r--r--lib/netdev.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/netdev.c b/lib/netdev.c
index 84874408a..45b50f26c 100644
--- a/lib/netdev.c
+++ b/lib/netdev.c
@@ -2063,7 +2063,8 @@ retry:
* address addition which may cause one of the returned
* ifa_name values to be NULL. In such case, we know that we've
* got an inconsistent dump. Retry but beware of an endless
- * loop. */
+ * loop. From glibc 2.28 and beyond, this workaround is not
+ * needed and should be eventually removed. */
freeifaddrs(if_addr_list);
goto retry;
} else {