diff options
| author | Ben Pfaff <blp@ovn.org> | 2021-01-21 14:49:22 -0800 |
|---|---|---|
| committer | Ben Pfaff <blp@ovn.org> | 2021-02-02 09:51:59 -0800 |
| commit | c3da0ae652137457c7abe1ebcd2b049178d69a66 (patch) | |
| tree | b4b925b2282b827f0618ad088fe950c8c4565d87 /lib/ofp-table.c | |
| parent | 83f5e6fda9e96d5a5a1e31a163c61b2cbb5d817d (diff) | |
| download | openvswitch-c3da0ae652137457c7abe1ebcd2b049178d69a66.tar.gz | |
ofp-table: Improve log message in ofputil_decode_table_features().
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Ilya Maximets <i.maximets@ovn.org>
Diffstat (limited to 'lib/ofp-table.c')
| -rw-r--r-- | lib/ofp-table.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/lib/ofp-table.c b/lib/ofp-table.c index 6ed6c5e3b..a956754f2 100644 --- a/lib/ofp-table.c +++ b/lib/ofp-table.c @@ -523,9 +523,12 @@ ofputil_decode_table_features(struct ofpbuf *msg, /* OpenFlow 1.3 and 1.4 always require all of the required properties. * OpenFlow 1.5 requires all of them if any property is present. */ - if ((seen & OFPTFPT13_REQUIRED) != OFPTFPT13_REQUIRED - && (tf->any_properties || oh->version < OFP15_VERSION)) { - VLOG_WARN_RL(&rl, "table features message missing required property"); + unsigned int missing = (seen & OFPTFPT13_REQUIRED) ^ OFPTFPT13_REQUIRED; + if (missing && (tf->any_properties || oh->version < OFP15_VERSION)) { + VLOG_WARN_RL(&rl, + "table features message missing %u required " + "properties, including property %d", + count_1bits(missing), rightmost_1bit_idx(missing)); return OFPERR_OFPTFFC_BAD_FEATURES; } |