lib: Remove extra API dependency for ovs_thread_create()

When calling ovs_thread_create() without calling fatal_signal_init()
first, ovs_thread_create() some times asserts. This dependency is
subtle and not very obvious.

The root cause seems to be that, within ovs_thread_create(), the
multi-threaded state is declared before all initializations are done.

Signed-off-by: Andy Zhou <azhou@ovn.org>
Acked-by: Ben Pfaff <blp@ovn.org>

1 files changed, 1 insertions, 1 deletions

diff --git a/lib/ovs-thread.c b/lib/ovs-thread.c
index eee8d9e45..aa0aab291 100644
--- a/lib/ovs-thread.c
+++ b/lib/ovs-thread.c
@@ -372,7 +372,6 @@ ovs_thread_create(const char *name, void *(*start)(void *), void *arg)
     int error;
 
     forbid_forking("multiple threads exist");
-    multithreaded = true;
 
     if (ovsthread_once_start(&once)) {
         /* The first call to this function has to happen in the main thread.
@@ -389,6 +388,7 @@ ovs_thread_create(const char *name, void *(*start)(void *), void *arg)
         ovsthread_once_done(&once);
     }
 
+    multithreaded = true;
     aux = xmalloc(sizeof *aux);
     aux->start = start;
     aux->arg = arg;