diff options
| author | Ilya Maximets <i.maximets@samsung.com> | 2016-06-24 16:28:32 +0300 |
|---|---|---|
| committer | Daniele Di Proietto <diproiettod@vmware.com> | 2016-06-24 14:43:29 -0700 |
| commit | 1f5b157ece72c6ed346a48309b29ea0a2e1c0c63 (patch) | |
| tree | 669b5c88b7b6404785e8f57c16ccb56cbf4c78fb /lib | |
| parent | 0b1162905b11dbd0bbee754b1908e27ac21cf730 (diff) | |
| download | openvswitch-1f5b157ece72c6ed346a48309b29ea0a2e1c0c63.tar.gz | |
netdev-dpdk: Fix using uninitialized link_status.
'rte_eth_link_get_nowait()' works only with physical ports.
In case of vhost-user port, 'link' will stay uninitialized and there
will be random messages in log about link status.
Ex.:
|dpdk(dpdk_watchdog2)|DBG|Port -1 Link Up - speed 10000 Mbps - full-duplex
Fix that by calling 'check_link_status()' only for physical ports.
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Acked-by: Aaron Conole <aconole@redhat.com>
Acked-by: Daniele Di Proietto <diproiettod@vmware.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/netdev-dpdk.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index ed14a21e1..02e2c58c9 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -567,7 +567,9 @@ dpdk_watchdog(void *dummy OVS_UNUSED) ovs_mutex_lock(&dpdk_mutex); LIST_FOR_EACH (dev, list_node, &dpdk_list) { ovs_mutex_lock(&dev->mutex); - check_link_status(dev); + if (dev->type == DPDK_DEV_ETH) { + check_link_status(dev); + } ovs_mutex_unlock(&dev->mutex); } ovs_mutex_unlock(&dpdk_mutex); |