summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorThadeu Lima de Souza Cascardo <cascardo@redhat.com>2016-09-30 18:53:37 -0300
committerBen Pfaff <blp@ovn.org>2016-10-03 10:09:56 -0700
commit63460a30c53ee35b540831bd75fe86e9c2a46d7e (patch)
tree690fc2263738fb681c9f443a02ef4ffff900e100 /lib
parent0da610338225eef4ff3d149a1adadfe82c2b15f2 (diff)
downloadopenvswitch-63460a30c53ee35b540831bd75fe86e9c2a46d7e.tar.gz
tests/bundle: test bundle action with ports up and down
Also, add the keyword bundle_action to all the tests in bundle.at, distinguishing it from OF bundles. It came to my attention recently that bundle_load will load 0xFFFF in case all the slaves are down, as bundle_execute will return OFPP_NONE. As I noticed this was not explicitly tested, not even for the bundle action, I thought it would be nice to do it as a way of documenting this behavior. Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/ofp-actions.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index 15dbdec8d..16f0f7c09 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -1200,7 +1200,8 @@ format_OUTPUT_REG(const struct ofpact_output_reg *a, struct ds *s)
* generally take into account things like its carrier status and the results
* of any link monitoring protocols which happen to be running on it. In order
* to give controllers a place-holder value, the OFPP_NONE port is always
- * considered live.
+ * considered live, that is, NXAST_BUNDLE_LOAD stores OFPP_NONE in the output
+ * register if no slave is live.
*
* Some slave selection strategies require the use of a hash function, in which
* case the 'fields' and 'basis' parameters should be populated. The 'fields'