diff options
| author | Jarno Rajahalme <jarno@ovn.org> | 2017-02-23 11:27:55 -0800 |
|---|---|---|
| committer | Andy Zhou <azhou@ovn.org> | 2017-03-08 13:09:43 -0800 |
| commit | d61973d6d5e13c60c813678c12e1ac8a6b2d6ec9 (patch) | |
| tree | e2f824aa0f57248a67d5feff56542aa4cf460964 /ofproto/ofproto-dpif-trace.c | |
| parent | 5dddf9606517b149c6a00aa3508acd1048fdae63 (diff) | |
| download | openvswitch-d61973d6d5e13c60c813678c12e1ac8a6b2d6ec9.tar.gz | |
ofproto: Fix thread safety annotation.
ofproto_check_ofpacts() requires ofproto_mutex, but the header did not
tell that so the trace did not take the mutex.
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Signed-off-by: Andy Zhou <azhou@ovn.org>
Diffstat (limited to 'ofproto/ofproto-dpif-trace.c')
| -rw-r--r-- | ofproto/ofproto-dpif-trace.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ofproto/ofproto-dpif-trace.c b/ofproto/ofproto-dpif-trace.c index b01a13182..3c9e3d414 100644 --- a/ofproto/ofproto-dpif-trace.c +++ b/ofproto/ofproto-dpif-trace.c @@ -387,8 +387,10 @@ ofproto_unixctl_trace_actions(struct unixctl_conn *conn, int argc, ofproto->up.n_tables, &usable_protocols); } if (!retval) { + ovs_mutex_lock(&ofproto_mutex); retval = ofproto_check_ofpacts(&ofproto->up, ofpacts.data, ofpacts.size); + ovs_mutex_unlock(&ofproto_mutex); } if (retval) { |