diff options
| author | László Sürü <laszlo.suru@ericsson.com> | 2016-05-11 08:46:33 +0000 |
|---|---|---|
| committer | Jarno Rajahalme <jarno@ovn.org> | 2016-05-11 14:35:55 -0700 |
| commit | 62e2e74667e5eb87b6e93395022498e3b5d1d575 (patch) | |
| tree | 49d2da37ec62d8e280dd01bfff2de5a339245c5d /ofproto/ofproto-dpif-xlate.c | |
| parent | 7eca52f147eb332e3e66aa3e55e37bf9466009d5 (diff) | |
| download | openvswitch-62e2e74667e5eb87b6e93395022498e3b5d1d575.tar.gz | |
ofproto-dpif-xlate: fix for group liveness propagation
According to OpenFlow v1.3.5 specification a group is considered live,
if it has at least one live bucket in it. (6.5 Group Table
Modification Messages: "A group is considered live if a least one of
its buckets is live.")
However, OVS implementation incorrectly returns group as live when no
live bucket is found in group_is_alive() function of
ofproto-dpif-xlate.c.
Instead it should return true only if a live bucket is found (that is
!= NULL).
Signed-off-by: László Sűrű <laszlo.suru@ericsson.com>
Co-authored-by: Jan Scheurich <jan.scheurich@ericsson.com>
Signed-off-by: Jan Scheurich <jan.scheurich@ericsson.com>
Acked-by: Jarno Rajahalme <jarno@ovn.org>
Diffstat (limited to 'ofproto/ofproto-dpif-xlate.c')
| -rw-r--r-- | ofproto/ofproto-dpif-xlate.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 232180261..4ffd8ace0 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -1502,7 +1502,7 @@ group_is_alive(const struct xlate_ctx *ctx, uint32_t group_id, int depth) bucket = group_first_live_bucket(ctx, group, depth); group_dpif_unref(group); - return bucket == NULL; + return bucket != NULL; } return false; |