ofp-actions: Split ofpacts_check__() into many functions.

ofpacts_check__() was a huge switch statement with special cases for many
different kinds of actions.  This made it unwieldy and put the special
cases far away from the rest of the code related to a given action.  This
commit refactors the code to avoid the problem.

Signed-off-by: Ben Pfaff <blp@ovn.org>
Tested-by: Yifeng Sun <pkusunyifeng@gmail.com>
Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com>

1 files changed, 8 insertions, 4 deletions

diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index e71431129..4d72dd841 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -3507,10 +3507,14 @@ ofproto_packet_out_init(struct ofproto *ofproto,
      * check instructions (e.g., goto-table), which can't appear on the action
      * list of a packet-out. */
     match_wc_init(&match, opo->flow);
-    error = ofpacts_check_consistency(po->ofpacts, po->ofpacts_len, &match,
-                                      u16_to_ofp(ofproto->max_ports), 0,
-                                      ofproto->n_tables,
-                                      ofconn_get_protocol(ofconn));
+    struct ofpact_check_params cp = {
+        .match = &match,
+        .max_ports = u16_to_ofp(ofproto->max_ports),
+        .table_id = 0,
+        .n_tables = ofproto->n_tables
+    };
+    error = ofpacts_check_consistency(po->ofpacts, po->ofpacts_len,
+                                      ofconn_get_protocol(ofconn), &cp);
     if (error) {
         dp_packet_delete(opo->packet);
         free(opo->flow);