summaryrefslogtreecommitdiff
path: root/ofproto
diff options
context:
space:
mode:
authorThadeu Lima de Souza Cascardo <cascardo@redhat.com>2016-06-08 13:04:11 -0300
committerJoe Stringer <joe@ovn.org>2016-06-08 09:48:29 -0700
commit2f22698ff1c88f8eb911711b0f98757f0660ef95 (patch)
tree0f796af33dafa393d4a307cd4a4c763a7232225b /ofproto
parent59a0ef1dc329e7700e52f0e60b97b2822e28b2f5 (diff)
downloadopenvswitch-2f22698ff1c88f8eb911711b0f98757f0660ef95.tar.gz
ofproto-dpif-upcall: Prevent memory leak on log message.
When DPIF does not support UFID (like old kernels), it may print this message quite frequently, if using an OVS version that does not include the upstream fix af50de800ecb ("ofproto-dpif-upcall: Pass key to dpif_flow_get()."). Fixes: 64bb477f0568 ("dpif: Minimize memory copy for revalidation.") Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> Signed-off-by: Joe Stringer <joe@ovn.org>
Diffstat (limited to 'ofproto')
-rw-r--r--ofproto/ofproto-dpif-upcall.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c
index 13749501a..a18fc5a8d 100644
--- a/ofproto/ofproto-dpif-upcall.c
+++ b/ofproto/ofproto-dpif-upcall.c
@@ -2056,6 +2056,7 @@ log_unexpected_flow(const struct dpif_flow *flow, int error)
"unexpected flow (%s): ", ovs_strerror(error));
odp_format_ufid(&flow->ufid, &ds);
VLOG_WARN_RL(&rl, "%s", ds_cstr(&ds));
+ ds_destroy(&ds);
}
static void