diff options
| author | Ilya Maximets <i.maximets@ovn.org> | 2022-08-31 12:25:51 +0200 |
|---|---|---|
| committer | Ilya Maximets <i.maximets@ovn.org> | 2022-09-09 19:03:09 +0200 |
| commit | 49efc63ad8c9ef14248c82dceecf39377619c515 (patch) | |
| tree | 95e9739282cc5aa358fda65a61a1e3c728397d51 /ofproto | |
| parent | 4f5decf4ab3fd23a68116a7cb2052d209f08bf56 (diff) | |
| download | openvswitch-49efc63ad8c9ef14248c82dceecf39377619c515.tar.gz | |
ofproto-dpif-xlate: Fix error messages for nonexistent ports/recirc_ids.
If tnl_port_should_receive() is false, we're looking for a normal
port, not a tunnel one. And it's better to print recirculation IDs
in hex since they are typically printed this way in flow dumps.
Fixes: d40533fc820c ("odp-util: Improve log messages and error reporting for Netlink parsing.")
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Diffstat (limited to 'ofproto')
| -rw-r--r-- | ofproto/ofproto-dpif-xlate.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 9bba55710..b695baba9 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -1515,7 +1515,7 @@ xlate_lookup_ofproto_(const struct dpif_backer *backer, if (OVS_UNLIKELY(!recirc_id_node)) { if (errorp) { *errorp = xasprintf("no recirculation data for recirc_id " - "%"PRIu32, flow->recirc_id); + "%#"PRIx32, flow->recirc_id); } return NULL; } @@ -1556,8 +1556,8 @@ xlate_lookup_ofproto_(const struct dpif_backer *backer, if (errorp) { *errorp = (tnl_port_should_receive(flow) ? xstrdup("no OpenFlow tunnel port for this packet") - : xasprintf("no OpenFlow tunnel port for datapath " - "port %"PRIu32, flow->in_port.odp_port)); + : xasprintf("no OpenFlow port for datapath port " + "%"PRIu32, flow->in_port.odp_port)); } return NULL; } |