diff options
author | Anju Thomas <anju.thomas@ericsson.com> | 2018-09-24 22:59:34 +0530 |
---|---|---|
committer | Ben Pfaff <blp@ovn.org> | 2018-09-26 15:49:21 -0700 |
commit | 991f1f63f5803ce42bf9c11ee7d2d74f086a481b (patch) | |
tree | 2c879551e74989d9e178d4ca6c986eaa267157f1 /ofproto | |
parent | f836888d28ec89565f87609e06f48becb49e5079 (diff) | |
download | openvswitch-991f1f63f5803ce42bf9c11ee7d2d74f086a481b.tar.gz |
ofproto-dpif-xlate: Fix load balancing for select groups with MPLS.
Before this commit, OVS did not do load balancing for select group buckets
in case of mpls tagged packets. After an MPLS pop action, the expectation
is to trigger recirculation. This recirculation will ensure an RSS
re-computation which will ensure load balancing in case of select group
bucket. Due to a missing return statement before bucket selection, the
bucket selection in case of select group happens before the recirculation
and hence no load balancing is achieved.
Signed-off-by: Anju Thomas <anju.thomas@ericsson.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Diffstat (limited to 'ofproto')
-rw-r--r-- | ofproto/ofproto-dpif-xlate.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index d0e7c6b9f..6949595ba 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c @@ -4463,6 +4463,7 @@ pick_select_group(struct xlate_ctx *ctx, struct group_dpif *group) */ if (ctx->was_mpls) { ctx_trigger_freeze(ctx); + return NULL; } switch (group->selection_method) { |